You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make the Tauri command AppState rule consistent in src-tauri/src/AGENTS.md - #368
Clarify the Tauri command state requirements in src-tauri/src/AGENTS.md to eliminate conflicting guidance.
Commands that need domain state must request tauri::State<'_, AppState> and access subordinate state through its fields. Commands that need no managed state do not require a tauri::State parameter. Separately registered managed state follows the existing rules in the Managed state section.
Changes
Align the Tauri Commands guidance with the existing Managed state section.
Explicitly prohibit requesting unregistered subordinate state types.
Preserve existing command signatures and state registration.
No actionable comments were generated in the recent review.
Walkthrough
The Tauri command guidance now says that commands needing managed state must request tauri::State<'_, AppState> and access subordinate state through an AppState field. It also says commands must not request subordinate state types.
Assessment against linked issues
Objective
Addressed
Explanation
Clarify when commands request AppState and prohibit requests for subordinate state types [#358]
✅
Possibly related PRs
BarraDev/slashit#359: Changes the same managed-state guidance but describes a conflicting rule about managed roots.
Change: Other
Merge Risk: Minimal · up to 0407e
This is a documentation-only clarification of how Tauri commands request managed state. It does not change runtime behavior, so the risk of merging is minimal.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the AGENTS.md file and the Tauri command AppState rule. The change makes that rule consistent across two passages, which matches the title. It is specific enough to describe the main c…
Description check
The description states the PR clarifies Tauri command state requirements in src-tauri/src/AGENTS.md, covering when commands request tauri::State<'_, AppState>, how they reach subordinate state through…
Persistent State Integrity
The check "Persistent state integrity" applies to changed code that mutates persisted application state. This PR changes only one file, src-tauri/src/AGENTS.md (one line, +1/-1). The change is documen…
Recoverable Resource Lifecycle
The check is about lifecycle code for worktrees, tasks, migrations, or cleanup. It can fail when a change clears the last persisted reference to a resource before cleanup succeeds, or when failed clea…
Platform Boundary Safety
The check is not applicable. The reviewed range changes one file, src-tauri/src/AGENTS.md (status M), per git diff --name-status against the review base and head refs. That file is Markdown guidan…
Full details: Title check
Explanation
The title names the AGENTS.md file and the Tauri command AppState rule. The change makes that rule consistent across two passages, which matches the title. It is specific enough to describe the main change and does not claim unrelated work.
Full details: Description check
Explanation
The description states the PR clarifies Tauri command state requirements in src-tauri/src/AGENTS.md, covering when commands request tauri::State<'_, AppState>, how they reach subordinate state through AppState fields, and that unregistered subordinate state types are prohibited. This matches the raw summary and the PR objectives, which both describe a one-line wording change to the same file. It also lists validation steps and a linked issue (#358).
Full details: Persistent State Integrity
Explanation
The check "Persistent state integrity" applies to changed code that mutates persisted application state. This PR changes only one file, src-tauri/src/AGENTS.md (one line, +1/-1). The change is documentation text about Tauri command state parameters. It contains no executable code, no persistence writes, no shared-memory publication, and no read-modify-write logic. The check does not apply, so it passes. The PR author is shingonoide (provider-reported); author identity is not part of this check.
Full details: Recoverable Resource Lifecycle
Explanation
The check is about lifecycle code for worktrees, tasks, migrations, or cleanup. It can fail when a change clears the last persisted reference to a resource before cleanup succeeds, or when failed cleanup has no recovery path. The pull request changes one file, src-tauri/src/AGENTS.md, a documentation-only edit that is the single entry in the changed-file inventory (M src-tauri/src/AGENTS.md). It changes no worktree, task, migration, or cleanup code. The check does not apply, so it passes.
Full details: Platform Boundary Safety
Explanation
The check is not applicable. The reviewed range changes one file, src-tauri/src/AGENTS.md (status M), per git diff --name-status against the review base and head refs. That file is Markdown guidance. It adds no Rust, build, or test code, and it touches no Unix- or Windows-specific API, module, type, or test. Command signatures and lib.rs state registration are unchanged, per the PR description and linked issue scope. No platform-gating or cross-platform compile risk is introduced. The check therefore passes.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 27df25f and 0407e3d.
Files selected for processing: 1
src-tauri/src/AGENTS.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the Tauri command state requirements in
src-tauri/src/AGENTS.mdto eliminate conflicting guidance.Commands that need domain state must request
tauri::State<'_, AppState>and access subordinate state through its fields. Commands that need no managed state do not require atauri::Stateparameter. Separately registered managed state follows the existing rules in the Managed state section.Changes
Validation
scripts/check-agent-docs.shpassed (agent-docs: OK).src-tauri/src/AGENTS.mdchanged.Fixes #358