Repository navigation
fix(ui): use the SlashIt logo in the sidebar and name the Linux tray - #366
Merged
Merged
Conversation
The sidebar shows the canonical logo.svg, copied into the frontend build by Trunk, in place of a generic gradient S, and drops the Task orchestration subtitle. The collapsed sidebar keeps the logo alone with an accessible name. On Linux the tray hover name is the StatusNotifierItem Title, which libayatana takes from the GLib application name. That defaulted to the binary name (slashit-ui). The application name is now set to SlashIt before the tray is built. The libappindicator backend ignores tooltips, so the existing tooltip call is unchanged. Binary, bundle and application identifiers, IPC and persistent paths are unaffected.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logo.svgin place of the generic gradientS, and drop the "Task orchestration" subtitle. The collapsed sidebar shows the logo alone with the accessible nameSlashIt.Title. libayatana takes it from the GLib application name, which defaulted to the binary name (slashit-ui). The application name is now set toSlashItbefore the tray is built.Changes
index.html: one Trunkcopy-filedirective forlogo.svg, so the build serves the same file as the repository root.src/components/sidebar.rs: the header renders the logo image in both states.src-tauri/src/lib.rs: a Linux-only call tog_set_application_name("SlashIt")in the tray setup, declared withextern "C"like the existing declarations inrtprio_guard.rs. No dependency is added.Root cause (tray)
tauri::tray::TrayIconBuilder::tooltipis ignored by the libappindicator backend, which the defaulttray-iconfeatures select on Linux..title()maps to a persistent label, not a hover name. The live item'sTitleproperty wasslashit-ui, andToolTipwas empty. A scratch probe that uses the same libappindicator calls showedTitle= the program name by default andSlashItafterg_set_application_name("SlashIt").Not changed
productName, bundle identifiercom.barradev.slashit-app, IPC, persistent paths, updater.g_get_prgname) and therefore the process name.Validation
cargo check -p slashit-ui: passes, no warnings.cargo clippy -p slashit-ui -p slashit -- -D warnings: passes.cargo test -p slashit-frontend: 401 and 3 passed.trunk build: succeeds, andlogo.svgin the output is byte-identical to the root asset.window.__TAURI__: expanded sidebar shows the logo andSlashIt, the tagline is absent, noSglyph remains, the logo loads, collapse and expand work, and navigation works. Console showed only the errors from the stubbed backend.Titlechanges from the program name toSlashIt). The full application was not run for this PR.Limits
WebKitWebDriver).Title, but it was not tested there.