Repository navigation
ci(dogfood): run the refresh harness in the supervisor job - #364
Conversation
scripts/test-refresh-dogfood.sh checks the refresh script's read-only status report, its forward-only and expected-commit guards, and its rollback behavior. It was not run by CI. It runs in the supervisor harness job, which already runs the other dogfood harnesses with TMPDIR at the runner's temporary directory, and it needs no Rust toolchain: the supervisor and build are stubs, and the fixture repository is disposable, so no dogfood instance is started, stopped or built. The job's executable-bit check now covers the refresh scripts too.
|
No actionable comments were generated in the recent review. Walkthrough
Change: Other Merge Risk:
|
Summary
The
supervisor-harnessjob in.github/workflows/ci.ymlruns the dogfood supervisor and build harnesses. It does not runscripts/test-refresh-dogfood.sh, so CI does not check the refresh script's read-only status report, its forward-only and expected-commit guards, or its rollback behavior.This change adds a step that runs
scripts/test-refresh-dogfood.shin that job. It also extends the job's executable-bit check toscripts/refresh-dogfood.shandscripts/test-refresh-dogfood.sh. The change touches only.github/workflows/ci.yml.What the suite does
TMPDIR, which the job sets to the runner's temporary directory. The supervisor and the build are stub scripts that log their calls. The suite starts, stops and builds no dogfood instance and reads no installation state.scripts/refresh-dogfood.shwith the fixture as its working directory. Matching by command line alone picked a subshell with the same command line on bash 5.1, which is why this is not a name match.sha256sum,mktemp), awk, cut, sed, tr, grep, and Linux/proc. All of them are present onubuntu-22.04. It needs no Rust toolchain and no JJ.Verification
Run locally on the PR head, with
GIT_CONFIG_GLOBAL=/dev/nulland an isolatedTMPDIR:scripts/test-refresh-dogfood.sh: 23 passed, 0 failed, about 2 seconds, on bash 5.3 locally and inside anubuntu:22.04container (bash 5.1, the runner's version).actionlint .github/workflows/ci.yml: no findings.scripts/check-agent-docs.sh: OK.Limits