Skip to content

ci(dogfood): run the refresh harness in the supervisor job - #364

Merged
shingonoide merged 2 commits into
mainfrom
ci/refresh-dogfood-harness
Nov 18, 2026
Merged

shingonoide merged 2 commits into
mainfrom
ci/refresh-dogfood-harness

Conversation

@shingonoide

@shingonoide shingonoide commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The supervisor-harness job in .github/workflows/ci.yml runs the dogfood supervisor and build harnesses. It does not run scripts/test-refresh-dogfood.sh, so CI does not check the refresh script's read-only status report, its forward-only and expected-commit guards, or its rollback behavior.

This change adds a step that runs scripts/test-refresh-dogfood.sh in that job. It also extends the job's executable-bit check to scripts/refresh-dogfood.sh and scripts/test-refresh-dogfood.sh. The change touches only .github/workflows/ci.yml.

What the suite does

  • It works in a disposable git repository under TMPDIR, which the job sets to the runner's temporary directory. The supervisor and the build are stub scripts that log their calls. The suite starts, stops and builds no dogfood instance and reads no installation state.
  • Its one process signal targets only the refresh script's own process: the outermost ancestor that runs scripts/refresh-dogfood.sh with the fixture as its working directory. Matching by command line alone picked a subshell with the same command line on bash 5.1, which is why this is not a name match.
  • Its fixtures are removed on exit.
  • Runtime dependencies are bash, git, coreutils (sha256sum, mktemp), awk, cut, sed, tr, grep, and Linux /proc. All of them are present on ubuntu-22.04. It needs no Rust toolchain and no JJ.
  • The stubs exercise the refresh script's decisions and its reactions to stub results. The suite does not run the real supervisor, the real build, or the installed application.

Verification

Run locally on the PR head, with GIT_CONFIG_GLOBAL=/dev/null and an isolated TMPDIR:

  • scripts/test-refresh-dogfood.sh: 23 passed, 0 failed, about 2 seconds, on bash 5.3 locally and inside an ubuntu:22.04 container (bash 5.1, the runner's version).
  • actionlint .github/workflows/ci.yml: no findings.
  • The executable-bit check, copied from the workflow, passes for all six supervisor and build scripts.
  • scripts/check-agent-docs.sh: OK.

Limits

  • The job has a 15-minute timeout. The suite adds seconds to it.
  • The change does not alter the supervisor or build harnesses, or any documentation.
  • Hosted CI is the authoritative result for the Linux runner.

scripts/test-refresh-dogfood.sh checks the refresh script's read-only status
report, its forward-only and expected-commit guards, and its rollback behavior.
It was not run by CI. It runs in the supervisor harness job, which already runs
the other dogfood harnesses with TMPDIR at the runner's temporary directory, and
it needs no Rust toolchain: the supervisor and build are stubs, and the
fixture repository is disposable, so no dogfood instance is started, stopped or
built. The job's executable-bit check now covers the refresh scripts too.
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The supervisor-harness job now checks that refresh-dogfood.sh and test-refresh-dogfood.sh are executable. It also runs scripts/test-refresh-dogfood.sh with TMPDIR set to the runner’s temporary directory.

Possibly related PRs

Change: Other

Merge Risk: Minimal · up to 655af

This change adds CI coverage for the dogfood refresh scripts and checks that they are executable. No actionable merge risk was found, and hosted CI will confirm the result on the Linux runner.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title names the change: a CI step that runs the dogfood refresh harness in the supervisor job. The raw summary and objectives confirm the workflow now runs scripts/test-refresh-dogfood.sh there an…
Description check Passed The description states the purpose of the change: adding a step to the supervisor-harness job in .github/workflows/ci.yml that runs scripts/test-refresh-dogfood.sh, and extending the executable-bit ch…
Persistent State Integrity Passed Summary: The check does not apply to this PR's changed code. The PR changes only .github/workflows/ci.yml. It adds an executable-bit check for scripts/refresh-dogfood.sh and `scripts/test-refr…
Recoverable Resource Lifecycle Passed The check does not apply to this PR. Its failure condition covers changes to worktree, task, migration, or cleanup lifecycle code that clear the last persisted reference to a resource before cleanup s…
Platform Boundary Safety Passed Summary: The check passes. The PR adds no compiled code and no build-path change. It changes only the supervisor-harness job in .github/workflows/ci.yml, which adds a step that runs `scripts/test-…
Full details: Title check

Explanation

The title names the change: a CI step that runs the dogfood refresh harness in the supervisor job. The raw summary and objectives confirm the workflow now runs scripts/test-refresh-dogfood.sh there and extends the executable-bit check. It is concise and does not claim unrelated work. The title does not mention the executable-bit check, which is a secondary part of the change.

Full details: Description check

Explanation

The description states the purpose of the change: adding a step to the supervisor-harness job in .github/workflows/ci.yml that runs scripts/test-refresh-dogfood.sh, and extending the executable-bit check to the refresh and test scripts. It also covers the suite's design, local verification results, and limits. The description is specific and directly related to the changeset.

Full details: Persistent State Integrity

Explanation

Summary: The check does not apply to this PR's changed code. The PR changes only .github/workflows/ci.yml. It adds an executable-bit check for scripts/refresh-dogfood.sh and scripts/test-refresh-dogfood.sh, and a step that runs scripts/test-refresh-dogfood.sh with TMPDIR set to the runner temp directory. Evidence: - The ci.yml diff against origin/main shows only the executable-bit line extended and one new Run the dogfood refresh harness step. Both are CI configuration. - The PR description and raw summary both state that the change touches only ci.yml. - The test suite runs in a disposable git repository with stub supervisor and build scripts. Per the description, it starts, stops and builds no dogfood instance and reads no installation state. It does not mutate persisted application state, and this PR does not change the refresh script. Caveat: A local git diff --stat origin/main...HEAD listed many other files (including scripts/refresh-dogfood.sh and src-tauri code). This local base appears to differ from the PR's actual base, so I did not treat those files as part of this PR. The stated PR scope and the ci.yml diff are the basis for this verdict. Result: No changed code in this PR mutates persisted application state, so none of the three failure conditions (false success after failed persistence, publishing unpersisted state after failure, stale read-modify-write) can apply. The check passes.

Full details: Recoverable Resource Lifecycle

Explanation

The check does not apply to this PR. Its failure condition covers changes to worktree, task, migration, or cleanup lifecycle code that clear the last persisted reference to a resource before cleanup succeeds, or that leave a failed cleanup with no recovery path. The PR head has two commits on top of the base: - 655afbf (ci(dogfood): run the refresh harness in the supervisor job) changes .github/workflows/ci.yml. It extends the executable-bit check to scripts/refresh-dogfood.sh and scripts/test-refresh-dogfood.sh, and adds a step that runs scripts/test-refresh-dogfood.sh with TMPDIR set to the runner temp directory. - b80ca4e (fix(dogfood): kill the refresh script itself in the interrupted-refresh test) changes scripts/test-refresh-dogfood.sh by 12 lines. Neither commit touches worktree, task, migration, or production cleanup code. The test script runs in a disposable git fixture with stub supervisor and build scripts. It removes its own fixtures on exit and does not manage any persisted application resource. The PR description and the provider-reported PR metadata agree on this scope. A local origin/main...HEAD diff lists many more files. Those come from commits already on the base (for example #359–#363), not from this PR's commits, so I did not attribute them to this PR.

Full details: Platform Boundary Safety

Explanation

Summary: The check passes. The PR adds no compiled code and no build-path change. It changes only the supervisor-harness job in .github/workflows/ci.yml, which adds a step that runs scripts/test-refresh-dogfood.sh and extends an executable-bit check. Evidence: - The job runs on runs-on: ubuntu-22.04 (ci.yml line 75). The new step runs only on that Linux target, so no non-Linux CI target runs it. - The new test scripts/test-refresh-dogfood.sh uses Linux /proc (/proc/$p/cmdline, /proc/$p/cwd, /proc/$p/stat) for its interrupted-refresh case. This is a Unix-specific dependency. It is not gated by a uname check. Its behavior is still bounded: the only CI runner is Linux, and the PR description lists /proc as a runtime dependency. - The sibling scripts/supervise-dogfood.sh gates on uname -s and exits with unsupported platform (line 169). scripts/test-supervise-dogfood.sh is documented as Linux only (docs/development-workflow.md around line 1147 and 1384). The new test follows the same Linux-only scope. - No compile path is changed. The check's cross-platform compile-failure condition does not apply. Residual note (not a failure under this check): a developer running test-refresh-dogfood.sh on macOS or Windows would fail at runtime, not at compile time. The test has no explicit platform guard, unlike the supervisor script. This is a usability gap, not a compile-time boundary violation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: BarraDev/slashit
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: dc2769f
  • Layers: Repository YAML (base), Repository UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 66e0641a-4458-4f9e-8d85-270e6ae4f8b1
Commits

Reviewing files that changed from the base of the PR and between dc2769f and 655afbf.

Files selected for processing: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@shingonoide
shingonoide merged commit 6c2da69 into main Nov 18, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant