Fix Chinese/UTF-8 mojibake on QR import + long-press rename - #1588
Open
onewhitethreee wants to merge 2 commits into
Open
onewhitethreee wants to merge 2 commits into
onewhitethreee wants to merge 2 commits into
Conversation
Two independent decode bugs both mangled non-ASCII issuer/account names: - migration.ts decoded the Google Authenticator export protobuf's account/issuer bytes with String.fromCharCode (Latin-1), instead of UTF-8. - QrImport.vue/content.ts preferred the qrcode-reader library, which also decodes QR byte-mode data as Latin-1, over jsQR (UTF-8-correct), only falling back to jsQR on outright decode failure.
Long-pressing the issuer or account text now enables the existing edit mode and focuses/selects that entry's rename input, instead of requiring the user to open edit mode from the header first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migration.ts: decode the Google Authenticator export protobuf's account/issuer bytes withTextDecoderinstead ofString.fromCharCode(the latter treats each UTF-8 byte as Latin-1, garbling multi-byte characters).QrImport.vue/content.ts: tryjsQR(decodes byte-mode QR data as UTF-8) first, only falling back toqrcode-reader(Latin-1, garbles non-ASCII) when jsQR fails to find a code.Test plan
chrome/build output