Skip to content

feat: add SBP bundle approval and rejection emails - #301

Merged
amandazhuyilan merged 1 commit into
mainfrom
SBP-674-add-SBP-bundle-emails
Oct 9, 2026
Merged

amandazhuyilan merged 1 commit into
mainfrom
SBP-674-add-SBP-bundle-emails

Conversation

@amandazhuyilan

@amandazhuyilan amandazhuyilan commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

SBP-674: add SBP bundle approval and rejection emails

Changes

  • Add sbp_portal_url setting (mirrors aai_portal_url's env-driven default pattern)
  • Add SBP-specific approval email (compose_sbp_bundle_approval_email + sbp_bundle_approved.html), using content here, linking to the SBP platform
  • Add SBP-specific rejection email (compose_sbp_bundle_rejection_email + sbp_bundle_rejected.html), using content here for the early-access invite-only period, linking to SBP support Freshdesk link.
  • Wire approve_group_membership to send the new SBP approval email instead of the generic bundle-approval email
  • Wire reject_group_membership to send the new SBP rejection email — previously SBP rejections sent no email at all (only TSI did)
  • Add tests: composer unit tests, end-to-end admin API tests, and an sbp_group fixture

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

Test plan

All tests shall pass!

image image

@marius-mather marius-mather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! good to go

@amandazhuyilan
amandazhuyilan merged commit 6e8b92e into main Oct 9, 2026
5 checks passed
@amandazhuyilan
amandazhuyilan deleted the SBP-674-add-SBP-bundle-emails branch October 9, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants