Repository navigation
feat: add SBP bundle approval and rejection emails - #301
Merged
Merged
Conversation
marius-mather
approved these changes
Oct 9, 2026
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
looks great! good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SBP-674: add SBP bundle approval and rejection emails
Changes
sbp_portal_urlsetting (mirrorsaai_portal_url's env-driven default pattern)compose_sbp_bundle_approval_email+sbp_bundle_approved.html), using content here, linking to the SBP platformcompose_sbp_bundle_rejection_email+sbp_bundle_rejected.html), using content here for the early-access invite-only period, linking to SBP support Freshdesk link.approve_group_membershipto send the new SBP approval email instead of the generic bundle-approval emailreject_group_membershipto send the new SBP rejection email — previously SBP rejections sent no email at all (only TSI did)sbp_groupfixtureChecklist
Test plan
All tests shall pass!