Update default model, OpenAI request options, and JET compat - #16
Conversation
- Switch DEFAULT_MODEL to gpt-6-luna - Pass reasoning_effort="none" to chat completions - Allow SHA 1.x - Support JET 0.12 and use target_modules in tests
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f67247a24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Dict("role" => "system", "content" => system_promptfn(lang)), | ||
| Dict("role" => "user", "content" => string(doc)), | ||
| ]; | ||
| reasoning_effort = "none", |
There was a problem hiding this comment.
This option is now attached to every request, including calls made after switchmodel! selects a non-reasoning model such as the previous gpt-4o-mini-2024-07-18, or when OPENAI_BASE_URL_OVERRIDE targets a compatible backend that does not implement this field. Such endpoints reject the request rather than translating, so the option should be conditional on a supporting model/provider or exposed as an opt-in request option.
Useful? React with 👍 / 👎.
1 participant
Summary
DEFAULT_MODELtogpt-6-lunareasoning_effort = "none"to chat completionsSHA1.xtarget_modulesAPINotes
target_defined_modulesconfig, sotest/jet_tests.jlnow usestarget_modules = (DocstringTranslation,), which works on JET 0.9 / 0.11 / 0.12.