Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Prompt to select estimated post filter if not shown and filter param change is done" from #10.
After "Recalculate filters", if estimates are available but no Estimated post-filter checkbox is ticked, a line under the buttons says so and offers "Show estimated". That ticks the estimate for each gyro/axis whose pre or post line is shown (or all, if none are). The line hides again once any estimate is visible, on reset, and when the estimates are already shown.
Only the Recalculate filters button triggers it (via a small
recalculate_filters()wrapper), so loading a log or a param file doesn't show it. The Setup fieldset usesmin-heightso the line fits.Checked on a batch log: hint after a notch change and recalculate, then all three axes shown after "Show estimated", and no hint on the next recalculate.