ci: use the repo-local antelope core instead of a global install - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
pnpm add --global @antelopejs/corestep from the CI workflow.@antelopejs/core(^1.9.1) is already a devDependency, andpnpm testrunsajs module test .through a package.json script, so pnpm resolvesajsfromnode_modules/.bin. The global install was redundant and could mask a missing or mismatched local core.Related issue
N/A — part of the org-wide cleanup removing the global antelope core install from CI workflows.
Verification
Ran every CI step locally, in order, on Node 24 with
PATHstripped of any globalajs(command -v ajsreturned nothing; inside pnpm scripts it resolved to./node_modules/.bin/ajs):pnpm install --frozen-lockfilepnpm prepackpnpm lint(warnings only, no errors)pnpm format:checkpnpm knippnpm test— 83 passingCI on this pull request validates the same steps without the global install.
Checklist