chore(deps): move to @antelopejs/dms-frontend 0.3.0 - #22
Open
alessaloisio wants to merge 1 commit into
Open
alessaloisio wants to merge 1 commit into
alessaloisio wants to merge 1 commit into
Conversation
@antelopejs/dms-frontend 0.3.0 removes the useColorMode shim (AntelopeJS/dms-frontend#43). @antelopejs/dms 0.4.2 and earlier still call it from Settings > Appearance, which fails with "useColorMode is not defined" on the new renderer. dms 0.4.3 (AntelopeJS/dms#56) keeps the preference in its own dms-color-mode cookie, renders the color class on the server and requires dms-frontend 0.2.8 or later. This module's own query builder imports useColorMode from @vueuse/core since 0.0.9 (#21), so it no longer depends on the shim either. Pin dms-frontend 0.3.0 in the playground and raise the @antelopejs/dms minimum to 0.4.3 everywhere this repository selects it, so the new renderer can no longer be paired with a dms that calls the removed shim: - the playground dependency; - the dms module source in playground/antelope.config.ts, which the core resolves against the registry at startup and, when offline, falls back to any cached version the range still allows; - the test harness module source, kept on the same floor as the playground. The playground loads this module from the local checkout, so no dms-database range needs raising here. The playground lockfile moves dms 0.4.0 -> 0.4.3 and dms-frontend 0.2.6 -> 0.3.0.
11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@antelopejs/dms-frontend 0.3.0 removes the
useColorModeshim (AntelopeJS/dms-frontend#43, breaking).ReferenceErrorat runtime, orTS2304: Cannot find name 'useColorMode'inajs dms verify-source.dms-color-modecookie (fix(layout): keep the color-mode preference in a dms-color-mode cookie dms#56) and requires dms-frontend ≥ 0.2.8: shared cookie refs read from the rendered request, fix(vue): share cookie refs and read them from the rendered request dms-frontend#36.This PR moves the repo to renderer 0.3.0 and raises every selector of
@antelopejs/dmsto ≥ 0.4.3, so renderer 0.3.0 can only be combined with a dms that no longer uses the shim. Atype: "package"module source is resolved against the registry at startup, but offline the core falls back to any cached version the range still allows, so>=0.4.0could serve a cached 0.4.0–0.4.2.Changes
playground/antelope.config.ts:version: ">=0.4.0 <1.0.0",→version: ">=0.4.3 <1.0.0",playground/package.json:"@antelopejs/dms": ">=0.4.0 <1.0.0",→"@antelopejs/dms": ">=0.4.3 <1.0.0",playground/package.json:"@antelopejs/dms-frontend": "0.2.6",→"@antelopejs/dms-frontend": "0.3.0",src/test/harness.ts:version: ">=0.4.0 <1.0.0",→version: ">=0.4.3 <1.0.0",playground/pnpm-lock.yaml: resolved to dms-frontend 0.3.0 (and dms 0.4.3 where it is locked)Related issue
Tracked in AntelopeJS/dms-frontend#45 (goal, compatibility matrix, all PRs and follow-ups). Follows AntelopeJS/dms-frontend#43 (shim removal, v0.3.0), AntelopeJS/dms#56 (dms 0.4.3) and AntelopeJS/dms#55 (color-mode rollout).
Verification
/auth/login): dark →class="dark", light →class="light", no cookie → no color class; exactly onescript#dms-color-mode. Backend and frontend started cleanly.How to test
pnpm install, then the repo'slint,typecheckandtestscripts. See Verification for the expected exit codes..antelope/dev.jsonand "Server ready".curl -s -H 'Cookie: dms-color-mode=%22dark%22' http://localhost:3001/auth/login | grep -o '<html[^>]*>'containsclass="dark";%22light%22:class="light"; with no cookie: no color class;<script id="dms-color-mode".Merge order
Independent of the other repos' PRs, so any order works. Its prerequisites are already released: dms-frontend 0.3.0, @antelopejs/dms 0.4.3 and @antelopejs/dms-database 0.0.9. It only changes dependency floors, playground and test configuration, so it needs no release of its own unless the repo publishes its playground or test harness.
Checklist