Repository navigation
Keep Unity bridge checks in Python - #302
Merged
Eli Pinkerton (wallstop) merged 2 commits intoOct 19, 2026
Merged
Eli Pinkerton (wallstop) merged 2 commits into
Eli Pinkerton (wallstop) merged 2 commits into
Conversation
Retired Node hooks duplicate the Python bridge contracts. Replace the remaining JavaScript publication fixture with Python, remove the retired hooks, and map the new Python subjects to their contract suites. A zero-exit placeholder interpreter reproduced silent success without configuration. Both compatibility launchers now require a positive interpreter marker; uv must report its version. The placeholder regression fails before repair and passes after. Existing script names remain compatible. Strict pyright, Python 3.9 bridge contracts, the final fast check, and all 17 full gate steps pass. Native Windows validation covered the bridge and startup review repairs. The Python bridge also passed 395 EditMode and 15 PlayMode tests on the live Unity 6000.5.2f1 host; all eleven pre-existing asset GUIDs remain. Temporary validation processes and workspaces were removed. Refs #171. Inline release-workflow orchestration remains for the next bounded migration layer.
Eli Pinkerton (wallstop)
added this pull request to stack #297
October 18, 2026 21:36
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ee418c7. Configure here.
Launcher-only changes must run the positive interpreter probes as well as the shared HTTP and Python startup contracts. The original selection omitted the catalog suite that owns the new data-driven launcher regression. Verified the launcher probe selection before and after the repair; catalog and scope suites pass, as does the changed-file fast check. Refs #171; addresses PR #302 review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: Retired Node hooks still duplicate the Python bridge contracts.
What:
Refs #171.
Type of Change
Checklist
Note
Low Risk
Changes are limited to devcontainer/MCP tooling, docs, and test harness mappings; launcher probing only affects how npm scripts pick uv/Python on the host PATH.
Overview
This PR finishes the Node → Python handoff for MCP config sync and the Unity MCP HTTP bridge: docs now point at
scripts/mcp_configure.pyandscripts/unity_mcp_host.py, while the.mjsentry points stay as thin launchers only.The launchers probe interpreters for real output (
uvversion string, Python printsdataviz-python) so a PATH placeholder that exits 0 is no longer mistaken for a usable runtime. Integration tests drop the retired Node bridge paths and Node publication fixtures; host contracts run againstunity_mcp_host.pydirectly, with startup/route/self-check behavior covered by the existing Python unit suite (test_unity_mcp_host_python.py).harness_scope.pymaps the Python subjects to the right contract tests, andtest_mcp_catalog.pyadds coverage that legacy launchers skip fakepython3shims.Reviewed by Cursor Bugbot for commit 14e6ea9. Bugbot is set up for automated code reviews on this repo. Configure here.