Repository navigation
Run MCP setup without requiring Node - #298
Merged
Eli Pinkerton (wallstop) merged 1 commit intoOct 19, 2026
Merged
Eli Pinkerton (wallstop) merged 1 commit into
Eli Pinkerton (wallstop) merged 1 commit into
Conversation
The universal configurator still owns orchestration in Node after its persistence adapters moved to Python. Move orchestration to typed Python and let the Python sync wrapper work without Node. Retain the old Node command as a launcher with validated Python 3.9 fallback. All ten generated files match the former Node implementation byte for byte for open and authenticated bridge cases, including quoted URLs and non-ASCII workspaces. Dry runs, independent writer failures, logical paths, missing uv, and credential aliases pass their contracts. The sync suite passes on actual Python 3.9.25; strict pyright reports zero errors. The 17-step gate passes the full harness suite. The unchanged C# state passed 395 EditMode and 15 PlayMode tests in the preceding stack layer. Refs #171. The Unity HTTP host remains for a separate migration layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: MCP configuration still depends on Node after persistence moved to Python.
What:
Refs #171.
Type of Change
Checklist
Note
Medium Risk
Refactor touches how all agent frontend MCP configs are generated, but behavior is preserved via contract tests; residual risk is launcher/path edge cases on hosts without
uvor Python 3.9+.Overview
MCP configuration no longer depends on Node for orchestration. The universal configurator logic that lived in
configure.mjsis now implemented inscripts/mcp_configure.py, which drives the existing Python helpers (mcp_aliases,mcp_catalog,mcp_json_config,mcp_codex_config) and keeps the same multi-frontend write plan,--checkdry runs, per-frontend success/failure reporting, and status output (Unity bridge URL, credential alias divergence, optionaluv/uvxservers).sync_mcp.pyinvokes the Python configurator directly instead of spawning Node.configure.mjsremains as a thin compatibility launcher that forwards touv runor Python 3.9+.Contract tests were updated so sync/credential cases run without Node (including a new case that sync
--checksucceeds with an emptyPATH), and the MCP README documents the Python entry point.Reviewed by Cursor Bugbot for commit a5ae7d2. Bugbot is set up for automated code reviews on this repo. Configure here.