Repository navigation
Reduce the gap between object rows - #296
Merged
Eli Pinkerton (wallstop) merged 1 commit intoOct 19, 2026
Merged
Conversation
Object rows leave excessive vertical space. Reduce the fixed slot from 46 to 40 points while retaining card and control dimensions. Share the slot height with ListView virtualization. Rendered Dx gap falls from 10 to 4 pixels at pixelsPerPoint 1, a 60 percent reduction. The new render regression fails at 10 points on the base and passes for all six shipped themes after the fix. Refresh the README layout capture and its pixel-verified lossless WebP. The full EditMode rerun passes 395 tests. One earlier run failed an existing theme-reset color transition assertion; its focused rerun passes. The 17-step repository gate and scoped image exporter tests pass. Revert this commit to restore prior spacing. Fixes #292.
Eli Pinkerton (wallstop)
added this pull request to stack #297
October 18, 2026 20:39
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c7ec4e5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: Object rows leave too much vertical space between cards.
What:
Fixes #292.
Type of Change
Checklist
Note
Low Risk
Layout-only constant tweak with regression tests across themes; no data, auth, or API behavior changes.
Overview
Tightens the virtualized object ListView by lowering
ObjectRowFixedHeightfrom 46px to 40px, cutting the default vertical gap between object cards by more than half without changing card padding or action controls.Adds an editor UnityTest (
ObjectRowLayoutTests) that builds paired object rows, applies every shipped theme (Dx, Classic, Nord, Dracula, Compact, Minimal), and asserts cards do not overlap, Dx gap stays ≤5px, and row buttons remain inside each card’s bounds. CHANGELOG documents the layout change for #292.Reviewed by Cursor Bugbot for commit c7ec4e5. Bugbot is set up for automated code reviews on this repo. Configure here.