Repository navigation
Add gamepad navigation and current search match markers - #324
Merged
Merged
Conversation
This was referenced Oct 19, 2026
Open
Why A held stick restarted navigation after Cancel returned command focus. What changed - Track cancellation across direct and PlayerInput calls. - Ignore held directions until neutral and reset on ownership loss. - Cover mixed bindings and action-map handoff with queued gamepad input.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c16e00. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why:
Gamepad input cannot reach terminal controls, and search navigation lacks a visible current row.
Refs #241, #242, #245
What:
Note
Medium Risk
Touches PlayerInput routing, UI Toolkit focus/navigation suppression, and cancel/repeat state—behavioral regressions are possible outside the expanded Play Mode suites, though risk is mitigated by broad new tests.
Overview
Adds gamepad- and keyboard-driven UI navigation for the open terminal via new
Navigate,Submit, andCancelInput System routes, with header focus styling and repeat/cancel semantics (including blocking held stick input until neutral).TerminalPlayerInputControllernow serializes per-route action names, resolvesMapName/ActionName, and routes both defaultSend MessagesandInvoke C Sharp Eventsthrough shared protected hooks; when those actions are enabled and bound it suppresses duplicate native UI Toolkit move/submit/cancel on the terminal root.TerminalUIgainsNavigate/SubmitNavigation/CancelNavigation, queued navigation event tracking, and a current log-search match row (terminal-output-label--current-match) that updates on Prev/Next without altering text selection (including collapsed repeats).Docs, changelog, and tests expand coverage for custom action maps, gamepad flows, native-vs-owned navigation, and capture assertions; repo style rules now forbid expression-bodied members (with related formatting/doc updates).
Reviewed by Cursor Bugbot for commit 17e9101. Bugbot is set up for automated code reviews on this repo. Configure here.