Repository navigation
Use supported object searches on Unity 6000.4 #628
Description
Unity 6000.4.6f1 emits four package CS0618 warnings from Message Monitor and Flow Graph object searches. The obsolete overload remains selected until UNITY_6000_5_OR_NEWER. Three Diagnostics Tooling Exerciser searches use the same guard.
Question: can these five searches use the replacement overload starting with Unity 6000.4 while preserving scene discovery and the supported floor?
Baseline and RED: original source is unchanged. The installed 6000.4.6f1 public API marks the sort-mode overload obsolete and exposes the non-obsolete generic overload taking FindObjectsInactive. Local metadata is retained at .artifacts/unity-mcp/s465-find-objects-api.json. Unity's tagged 6000.4.0f1 source also exposes the replacement. 6000.4 documentation confirms the deprecation and inactive-object option.
Hypothesis: lower only the five FindObjectsByType guards from 6000.5 to 6000.4. Keep Include/Exclude choices, the pre-6000.4 branches, filtering, and sorting behavior unchanged.
GREEN checks: verify the exact source diff and line endings; compile on the connected 6000.4.6f1 editor; inspect the retained full console segment; run both affected window fixtures and sample contracts using the existing native runner, including a persistent-domain repeat. Use existing production-behavior coverage. Run practical format, spell, and package checks before a single reviewable push. Older versions remain pending CI verification until supported matrix results exist.
Stop rule: retain any compiler failure, discovery regression, native test failure, or cleanup error. Do not suppress obsolete warnings, weaken tests, extend native deadlines, alter SDK versions, or claim the full release gate is met.
Evidence location: .artifacts/unity-mcp/s465-object-search/ and ignored progress/session-465-object-search.md. Work in an isolated checkout and restore temporary host source after local verification. Human review remains required.
Accepted after merge
The final scope contains six guards, including FindRunner as preregistered in comment6165853669. Native Unity 6.4 first/repeat, exact-head supported-version CI, local checks and source reconciliation are qualified; wallstop merged the correction through PR619. See the closing evidence comment for exact matching scopes, later-file differences and limits. The issue is complete; final release gates remain open.
Activity
wallstop commentedon Oct 14, 2026
Before implementation: extend the existing scene-discovery test in each window fixture with active and inactive cases. Both cases must find the scene component and exclude the persistent prefab. This protects the existing Include behavior through the API change. No thresholds or native deadlines change. The imported host sample is older than the shipped source and has additional obsolete identity reads; preserve it and qualify the shipped sample through source contracts and the supported CI compile matrix.
wallstop commentedon Oct 14, 2026
Primary-source review found one more instance of the same version-boundary problem before finalizing the candidate:
DiagnosticsToolingGuideWindow.FindRunnerselects obsoleteFindFirstObjectByTypeon 6000.4. The exact 6000.4.0f1 Unity source marks it obsolete and exposes non-obsoleteFindAnyObjectByType. The sample already uses FindAny on 6000.5. Extend that existing guard to 6000.4 as well, preserving its active-only lookup and every older branch. Retain the first five-search candidate results separately; re-run the final six-search candidate's affected scope and source contracts without changing assertions or deadlines.wallstop commentedon Oct 14, 2026
Verdict: keep the six version-guard corrections for review in draft PR629, commit
88e7d4d9b3e75a62faed55c577ca562e7b12dff9.The installed Unity 6000.4.6f1 API and tagged 6000.4.0f1 source support the replacement overloads. Both loaded candidate windows use the one-argument Include overload. The original package windows produce four distinct CS0618 warnings. Offline C# 9 compilation of the exact shipped runtime/editor sample assemblies against 307 copied Unity/package reference files produces seven CS0618 warnings before and zero after. All four compiler legs exit zero; three existing serialized-field CS0649 warnings appear in both runtime legs. This is an offline API/compile check, not a Unity sample-behavior run.
Native evidence:
8f2b9eff-7687-4386-aea9-610b7824dee0.6f8e8f42-cc7b-46f2-8d72-309ebd39b9c5.0ce97438-6a0a-4bda-99ec-6748af9176f5and3d35449a-706e-46a5-b629-4899fbcf95c0. Every retained node passes, native cleanup identities match, framework errors are empty, and the original scene is restored clean.The final candidate console segment retains 130 entries without truncation, errors, or package warnings. C# formatting, Markdown, spelling,
validate:all, diff checks, and commit hooks pass. Initial formatting/harness/export preflight failures are retained locally; none are counted as passing checks. The pinned five-second metadata calls timed out before their unique proof files completed, with no relaunch.All seven temporary package source overlays are retired. Original five modules, SDK source/default timeout, 331 preservation pins, 344 source inventory entries, and the ten original worktree edits remain exact. The user's older imported sample under Assets remains untouched. Raw evidence stays private/local in
.artifacts/unity-mcp/s465-object-search/.Supported-version CI and wallstop review remain pending. The issue stays open. This change does not resolve #502's retained-capture defect or any release-readiness gate.
wallstop commentedon Oct 14, 2026
PR629's Prettier automation fails at the same inherited dependency gate as #620, before formatting runs. Job115803246667 completes
npm ci, thennpm audit --audit-level=highreports 15 affected dependency nodes (six high, one critical). This is separate from the object-search change and matches the existing audit investigation/fix in draft PR619. Preserve that reviewed fix and the audit gate; PR629 remains draft with CI/review pending.wallstop commentedon Oct 14, 2026
Supported-version CI is now qualified for PR629's exact head
88e7d4d9b3e75a62faed55c577ca562e7b12dff9. Unity run38549357506 executes all three modes on all four versions; each result-verification, artifact-redaction/upload, and license-return step succeeds. Counts from retained job logs:Every leg reports zero failures. The retained EditMode skips are not passing coverage; this does not qualify a complete release-readiness audit. Static CI and CSharpier automation also succeed. Devcontainer CI Success is green with both image jobs skipped by path filtering; Unity Docs Gate reports not applicable. These skips do not qualify those builds. The inherited Prettier dependency audit remains failed under #620; wallstop review is still required. No merge, issue closure, or release is performed.
wallstop commentedon Oct 16, 2026
Exact source integration review records the complete88e7d4d9 change: eight paths, six production search guards across five files (including one FindAnyObjectByType), two active/inactive Editor fixture expansions and its changelog bullet. The private combined710f130e preserves those exact deltas, the619 corrections and Node alignment; current catalog metadata also qualifies the full1463Node+2archive script gate. Final local integration verdict preserves old head-specific CI limits. This is not new Unity/floor/player or hostedCI qualification; PR629's own unchanged head retains its inherited audit failure. Code/copy review, publication disposition and coherent final integration remain pending. No PR push, merge or issue closure.
wallstop commentedon Oct 17, 2026
PR629 is now closed as superseded by existing draft PR619. This is source consolidation, not issue resolution. Published PR619/a4cb3a98 contains the object-search correction as885f51de. All seven non-changelog file blobs exactly match original PR629/88e7; its two added changelog lines are preserved exactly. Local inclusion proof: .artifacts/github/469-pr619-update/pr629-inclusion.json. Prior PR629 CI remains scoped to88e7; current integrated Unity CI39007807679 is queued. Wallstop review and final backend qualification remain required. #628 stays OPEN.
wallstop commentedon Oct 17, 2026
Integrated supported-backend qualification is now complete at draft PR619 head
fb43d0e6d69550fc6bf0d574d562af9fbd645e85. Exact source review verifies that all seven non-changelog blobs still match original PR629/88e7d4d9 byte-for-byte, and both original changelog lines remain. The complete-source Unity run39021298467attempt1 qualifies all four supported versions2021.3.45f1/2022.3.45f1/6000.3.16f1/6000.5.2f1, with source/run/job/artifact identity, byte/SHA checks and licensed cleanup verified.For every version, the raw Editor XML contains90MessageMonitor window cases,185FlowGraph window cases and8DiagnosticsTooling sample-contract cases, all283PASS with none skipped. Exact matching prior outcomes and all other current-head correctness cases are retained in the complete qualification: #639 (comment) . Local inclusion/individual-case evidence:
628-integrated-current-head-qualification-s469/qualified.json.This replaces the old queued-integrated-CI status; original6000.4.6f1 local component qualification remains scoped to its original unchanged correction, and this is not a new complete integrated6000.4local run. Wallstop code/copy review and final release-readiness gates remain required. PR619 stays draft; #628 remains OPEN, PR629 stays superseded/closed, and no merge or release occurs.
wallstop commentedon Oct 17, 2026
Local integrity seal for the integrated current-head qualification: .artifacts/perf-lab/628-integrated-current-head-qualification-s469, 3 files / 161254 bytes, MANIFEST SHA256 6c60d4b335fc5555eeefd191eeec9fe1952e606f51a532adb78a26fed0544cc1. Source and every XML input were hash-qualified before reduction; all 283 selected editor cases pass on each of the four supported CI versions.
The root is sealed: no later writes or executions. Readbacks after this seal stay external. This is local integrity evidence, not immutable experiment publication. The earlier local 6000.4 component run still has its original narrow scope; this does not claim a new full integrated 6000.4 run. Wallstop code/copy review remains required and #628 stays open.
wallstop commentedon Oct 29, 2026
Post-merge scoped acceptance audit completed against wallstop's PR619 merge
7ee780a5and current8aac5887.All 394 sealed original artifact hash/length bindings reverified. The final scope is six version guards, including the separately preregistered FindRunner correction (comment6165853669). All three complete sample source files, both affected window search methods, and both active/inactive discovery test methods plus their TestCase attributes are byte-identical from qualified
88e7d4d9through merged7ee780a5, qualified44894d33and current8aac5887. Other later window/test changes are not claimed byte-identical.Original Unity 6000.4.6f1 evidence retains the four package-window CS0618 warnings, candidate calls to the replacement Include overload, and an untruncated final console segment with no CS0618. The final six-guard candidate passes 282 actual native cases twice without a domain reload. The sample API check compiles the exact runtime/editor assemblies against copied actual Unity references in C#9: seven CS0618 warnings before, zero after, all four compiler legs exit zero. That is an offline compilation/API check; native sample-contract execution is a separate signal.
Exact-head supported-version CI run38549357506 and all four successful job/result/license-return records remain verified (see prior comment6167900946). Additional qualified
44894d33Editor XML retains 280 matching original passing case identities per version, including all four active/inactive discovery cases and seven sample-contract cases. Two historical source-name-formatting case identities do not match the newer roster and are explicitly excluded from that additional comparison. Original native cleanup, restoration of seven overlays and loaded modules, 331 preserved paths and 344 source-inventory entries remain verified. Wallstop's merge adopts the scoped correction.Local receipt
.artifacts/session484/acceptance-audits/628-integration-acceptance.json, SHA-25685fbb468cbc9814aab4f2fdc1c785630b7789fc7f88652c50c941014374ef309. This is a local integrity index; private Unity references and raw host logs are not published.Closing the completed object-search compatibility correction. This does not accept final copy or release readiness, claim allocation/performance results, or resolve PR693's separate formatter audit-step failure.