Fix test 04652: support Antalya build flavour in the settings history - #2404
Merged
Merged
Conversation
`04652_system_documentation_settings_history` builds its sort key from `system.settings_changes` by splitting the version on `.` and casting every part to `UInt32`, which throws on the `altinityantalya` suffix an Antalya version carries. The `26.8.1.20001.altinityantalya` block of `SettingsChangesHistory.cpp` therefore only worked while it was empty, and the first live entry in it fails the test with `Cannot parse string 'altinityantalya' as UInt32`. Use `toUInt32OrZero` for the sort key. `ClickHouseVersion` accepts at most four numeric components, so the suffix becomes a fifth, zero component that orders an Antalya version right after the upstream release it patches, the way `ClickHouseVersion` orders it. The version claimed by `**Introduced in:**` is extracted with `[0-9.]+`, which cuts the suffix off and so never equals the recorded version; extract the whole token instead. This one fires on an Antalya entry that introduces a setting, which is the shape of every entry in the older Antalya blocks. Related: #2379 (comment)
zvonand
added
port-antalya
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #2345
Changelog category (leave one):
CI/CD Options
Exclude tests:
Regression jobs to run: