Conversation
Kept the PR's credential-refresh logic and translated it to the shapes present on antalya-26.8: * ReadBufferFromAzureBlobStorage on antalya-26.8 has no lazy, once_flag guarded getBlobClient() accessor (upstream-only refactor), so the new refresh/retry paths use the existing eager `blob_client` member. * AzureObjectStorage::removeObjectImpl / removeObjectsBatchIfExists on antalya-26.8 have no `successful_objects` out-parameter (upstream-only), so the re-indented block keeps its bookkeeping without it. Adapted: ReadBufferFromAzureBlobStorage refresh paths use antalya-26.8's eager `blob_client` member instead of upstream's lazy `getBlobClient()` accessor Adapted: AzureObjectStorage delete paths drop the `successful_objects` out-parameter, which does not exist on antalya-26.8
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add option to cache vended credentials for REST catalogs; add a setting
vended_credentials_cache_ttl(seconds). 300 by default. 0 means no caching.Workflow [PR]
Sync PR [sync-upstream/pr/107960] (ClickHouse#107960 by @zvonand).
Cherry-picked from ClickHouse#107960.
Now, new vended credentials are requested on each metadata request. This PR adds an (optional) cache for creds with configurable TTL.