Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #2129 from Altinity/feature/antalya-26.6/pr-1761 Antalya 26.6: Support for 'time' type in Iceberg # Conflicts: # src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/Utils.cpp # src/Storages/ObjectStorage/DataLakes/Iceberg/Utils.h # tests/integration/test_database_iceberg/test.py
Kept both sides in the additive conflicts (decimal partition-value support on antalya-26.8 plus the new Time/Time64 helpers from #2129). Adapted: getAvroType() gained an `Int32 field_id` parameter on antalya-26.8 (unique Avro `fixed` names for decimal partition fields), so the new make_annotated_type() lambda from #2129 takes and forwards the field id.
zvonand
added
releasy
# Conflicts: # src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp # tests/integration/test_database_iceberg/test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support for 'time' type in Iceberg, read and write (#1761 by @ianton-ru) (#2129 by @zvonand).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #2129.
Documentation entry for user-facing changes
Solved #1535
This changes time format,.
Was - seconds from midnight:
Now - time with microseconds