⚡️Performance: Rework World Generation by Zoriot · Pull Request #201 · AlpsBTE/Plot-System

Zoriot · 2026-01-27T10:56:49Z

Summary

This PR reworks plot-world generation and loading to make it asynchronous and lifecycle-safe, while updating plot recovery, world-height handling, tutorial flows, and translation automation.

What changed

Moved plot-world file generation off the main server thread.
Added skeleton-world generation and reuse for faster, consistent plot-world creation.
Reworked plot loading into dedicated loader implementations for regular and tutorial plots.
Ensured Bukkit, Multiverse, WorldGuard, and FAWE operations run on the appropriate thread.
Added synchronization to prevent concurrent generation of the same plot world.
Improved plot-world recovery when an existing one-plot world is missing.
- Failed recovery no longer abandons or resets the existing plot.
- New plot generation still rolls back assignment when generation fails.
Preserved existing plot-world identity based on persisted plot type and legacy compatibility.
Updated teleport and review flows to prepare worlds before teleporting.
Improved passenger handling during plot teleportation.
Updated plot height validation to use the actual world height limits.
Added clearer generation-error logging, including the affected plot ID.
Updated tutorial plot generation and schematic-pasting behavior.
Removed the obsolete plot generator implementations and replaced them with the new loader architecture.
Updated project dependencies and Paper/Gradle compatibility.
Updated Crowdin workflows and upgraded the Crowdin GitHub Action.
Removed source-file license notices where no longer required.

Behavior and compatibility notes

The disable-city-inspiration-mode setting now affects new plot assignment only.
Existing City Inspiration Mode plots continue to resolve to their persisted city worlds.
Existing completed and unfinished one-plot worlds retain their database state if recovery fails

…a in PlotWorldGenerator

… loading

- measure old generator performance - add new AbstractPlotLoader, DefaultPlotLoader and PlotHandler

…ion-rework # Conflicts: # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/DefaultPlotGenerator.java

…into update/world-generation-rework

…ot Worlds to handle world specific abandon logic

…a in PlotWorldGenerator

… loading

- measure old generator performance - add new AbstractPlotLoader, DefaultPlotLoader and PlotHandler

…ot Worlds to handle world specific abandon logic

…into update/world-generation-rework # Conflicts: # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/world/PlotWorldGenerator.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/world/OnePlotWorld.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/world/PlotWorld.java

move savePlotAsSchematic to PlotHandler. create methods for both assigning and generating in PlotHandler. remove all old PlotGenerator files and replace every usage with the new PlotLoaders

…into update/world-generation-rework

…ion-rework # Conflicts: # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_Abandon.java # src/main/java/com/alpsbte/plotsystem/core/menus/companion/CityProjectMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/review/ReviewPlotTogglesMenu.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/DefaultPlotGenerator.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/utils/PlotUtils.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/world/CityPlotWorld.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/world/OnePlotWorld.java

…on-rework

Persist plot state consistently, prevent duplicate generation, and move heavy WorldEdit work onto FAWE's async executor.

- Now we don't construct a Air Mask in several places anymore. - We just use ignore air This fixes a issue where we adapt a cim world before it is actually loaded, that resulted into a fawe exception, which resulted in the plot not beeing pasted.

We switched to only the per repo license.

Teleporting called loadWorld(), which regenerated missing plot worlds and blocked on FAWE tasks that themselves need the main thread, freezing the server until the watchdog fired. World regeneration now lives in prepareWorld(), which callers invoke asynchronously before teleporting, and blocking waits fail fast when they run on the main thread.

This reverts commit 339d69b We paste it on the original position anyway so it's fine to fallback to 0 there

Prevent failed rebuilds of existing one-plot worlds from abandoning their plots, while retaining rollback behavior for newly assigned plots. Resolve existing plot worlds from persisted type and legacy compatibility instead of the new-plot CIM configuration.

Reduce schematic-save complexity, replace raw exception wrappers with specific completion exceptions, and document the tutorial loader lifecycle hook. Migrate tutorial menus, holograms, and NPC text to Adventure components and NamedTextColor.

…on-rework

…sed Utils#getConfiguredItem

Cinnazeyy and others added 26 commits July 14, 2025 04:17

move world generation to SkeletonWorldGenerator and copy skeleton dat…

77f41e2

…a in PlotWorldGenerator

generate skeleton on startup if not exists.

9263206

save skeleton to generate level.dat and remove uid.dat for multiverse…

573884f

… loading

fix async issues and cleanup generation related classes

d0b8173

add util methods for passing up exceptions in bukkit scheduler

16f0b39

- pass schematic bytes into generateOutlines method of PlotGenerators

779b31a

- measure old generator performance - add new AbstractPlotLoader, DefaultPlotLoader and PlotHandler

Merge branch 'update/1.21-data-abstraction' into update/world-generat…

337a972

…ion-rework # Conflicts: # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/DefaultPlotGenerator.java

feat(gen): ✨ update emptychunkgenerator and provide it outside of plugin

fb9fd47

Merge remote-tracking branch 'origin/update/world-generation-rework' …

a4af0e0

…into update/world-generation-rework

Implement plot abandon functionality in the PlotHandler and rework Pl…

198e014

…ot Worlds to handle world specific abandon logic

move world generation to SkeletonWorldGenerator and copy skeleton dat…

a87a7e3

…a in PlotWorldGenerator

generate skeleton on startup if not exists.

73e9def

save skeleton to generate level.dat and remove uid.dat for multiverse…

0783dc6

… loading

fix async issues and cleanup generation related classes

6571670

add util methods for passing up exceptions in bukkit scheduler

030be1f

- pass schematic bytes into generateOutlines method of PlotGenerators

fc403d6

- measure old generator performance - add new AbstractPlotLoader, DefaultPlotLoader and PlotHandler

feat(gen): ✨ update emptychunkgenerator and provide it outside of plugin

35931a8

Implement plot abandon functionality in the PlotHandler and rework Pl…

91e97ad

…ot Worlds to handle world specific abandon logic

fix incorrectly rebased imports

73db572

Implement TutorialPlotLoader.java.

a53c9f7

move savePlotAsSchematic to PlotHandler. create methods for both assigning and generating in PlotHandler. remove all old PlotGenerator files and replace every usage with the new PlotLoaders

remove unused imports

17a8376

add nbt dependency to gradle for parity with maven

3ca8cb7

Merge remote-tracking branch 'origin/update/world-generation-rework' …

e669434

…into update/world-generation-rework

fix merging issues

4a9a6ce

Zoriot assigned Cinnazeyy and Zoriot Jan 27, 2026

Zoriot added enhancement New feature or request high priority labels Jan 27, 2026

Zoriot added 11 commits August 25, 2026 21:12

Merge remote-tracking branch 'origin/main' into update/world-generati…

c0fc46f

…on-rework

fix(plot): make world generation lifecycle safe and asynchronous

7919385

Persist plot state consistently, prevent duplicate generation, and move heavy WorldEdit work onto FAWE's async executor.

chore: Throw exception when plot is outside of supported range

339d69b

fix: Use world heights for checking plot height range

dc6140c

chore: Remove License notice from source files

80935a9

We switched to only the per repo license.

ci: Update crowdin workflows

6bc1691

fix: Handle player passenger on teleport

2726556

fix: Handle nulls in last activity gracefully

86488fd

chore: Log Plot Id on Generation error

32f5964

Zoriot marked this pull request as ready for review September 8, 2026 17:25

LordTuxn self-requested a review September 12, 2026 15:22

LordTuxn reviewed Sep 12, 2026

View reviewed changes

Zoriot and others added 8 commits September 12, 2026 23:10

Revert "chore: Throw exception when plot is outside of supported range"

928e841

This reverts commit 339d69b We paste it on the original position anyway so it's fine to fallback to 0 there

fix: adjust plot structure generation to handle plots with environments

01ad7a3

fix: log world generation metrics only in dev mode

7c8aaa9

fix: normalize world name handling in config deletion

51d21ad

refactor: enhance command output formatting with Adventure API

e52b1f3

Merge remote-tracking branch 'origin/main' into update/world-generati…

348ffd3

…on-rework

Zoriot force-pushed the update/world-generation-rework branch from 4bb715b to 348ffd3 Compare September 12, 2026 21:14

Zoriot requested a review from LordTuxn September 12, 2026 21:15

refactor: simplify color references in action formatting + remove unu…

c05c465

…sed Utils#getConfiguredItem

Zoriot force-pushed the update/world-generation-rework branch from 78ceada to c05c465 Compare September 12, 2026 21:24

LordTuxn approved these changes Sep 12, 2026

View reviewed changes

ci: Skip ref checkout in crowdin action so it works from pr's

98beccb

Zoriot merged commit 197f65d into main Sep 12, 2026
2 checks passed

Zoriot deleted the update/world-generation-rework branch September 12, 2026 21:38

Navigation Menu

Uh oh!

Uh oh!

⚡️Performance: Rework World Generation - #201

⚡️Performance: Rework World Generation #201
Zoriot merged 73 commits into
mainfrom
update/world-generation-rework

Zoriot commented Jan 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Zoriot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Behavior and compatibility notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Zoriot commented Jan 27, 2026 •

edited

Loading