Skip to content

[PWGHF] Adding D0/Lc analysis task - #17808

Open
laszlogyulai wants to merge 19 commits into
AliceO2Group:masterfrom
laszlogyulai:master
Open

[PWGHF] Adding D0/Lc analysis task#17808
laszlogyulai wants to merge 19 commits into
AliceO2Group:masterfrom
laszlogyulai:master

Conversation

@laszlogyulai

Copy link
Copy Markdown

Adding a new analysis task for calculating the D0/Lambda_c yield ratio as a function of flattenicity

@github-actions github-actions Bot added the pwghf PWG-HF label Sep 7, 2026
@github-actions github-actions Bot changed the title Adding D0/Lc analysis task [PWGHF] Adding D0/Lc analysis task Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 7 warnings, 🔕 0 disabled

@laszlogyulai

Copy link
Copy Markdown
Author

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

@vkucera

vkucera commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Please consider the following formatting changes to AliceO2Group#17808
@laszlogyulai

Copy link
Copy Markdown
Author

Dear codeowners,
Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Dear Vit,

Thank you for the nice and easy solution to the issue. Everything should be fine now.

@vkucera

vkucera commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Dear codeowners,
Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Dear Vit,

Thank you for the nice and easy solution to the issue. Everything should be fine now.

Thanks @laszlogyulai for the implementation. It looks indeed much better now.

Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated
Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated
@vkucera

vkucera commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Since you are adding a new file, please fix also the warnings.

Please consider the following formatting changes to AliceO2Group#17808
@laszlogyulai

Copy link
Copy Markdown
Author

Dear code owners,

Can you tell me if anything is needed from my side at this point?

@vkucera

vkucera commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Dear code owners,

Can you tell me if anything is needed from my side at this point?

You have not fixed the warnings.

Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated
Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated
laszlogyulai and others added 2 commits September 11, 2026 11:32
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants