Skip to content

[ALICE3] Fix includes - #17784

Merged
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-ALICE3
Sep 9, 2026
Merged

[ALICE3] Fix includes#17784
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-ALICE3

Conversation

@vkucera

@vkucera vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the alice3 label Sep 5, 2026
@github-actions github-actions Bot changed the title Fix includes [ALICE3] Fix includes Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 27 errors, ⚠️ 175 warnings, 🔕 0 disabled

@vkucera
vkucera marked this pull request as ready for review September 6, 2026 14:27
@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bede0e2 at 2026-09-07 17:18:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 41 errors and 39 warnings.'
Found 41 errors and 39 warnings.
++ [[ 41 -gt 0 ]]
++ cat /sw/BUILD/681f09f988bb56b7f0767a7d5927b2235c1164e3/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:75:37: error: variable 'h2dInnerTimeResTrack' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:76:37: error: variable 'h2dInnerTimeResTotal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:77:37: error: variable 'h2dOuterTimeResTrack' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:78:37: error: variable 'h2dOuterTimeResTotal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:79:52: error: variable 'h2dInnerNsigmaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:80:52: error: variable 'h2dOuterNsigmaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:81:52: error: variable 'h2dInnerDeltaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:82:52: error: variable 'h2dOuterDeltaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:84:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:219:27: error: unused local variable 'histPath' of type 'const std::string' (aka 'const basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:352:17: error: member 'layerRadius' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:353:17: error: member 'layerLength' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:354:17: error: member 'pixelDimensionZ' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:355:17: error: member 'pixelDimensionRPhi' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:356:17: error: member 'fractionInactive' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:357:17: error: member 'magField' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:391:7: error: 'axisZ' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:401:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:406:35: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:460:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:467:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:487:13: error: variable 'x' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:487:16: error: variable 'y' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:487:19: error: variable 'z' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:492:12: error: variable 'b' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:775:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
ALICE3/TableProducer/alice3Multiplicity.cxx:43:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:58:9: error: variable 'inputPath' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:103:9: error: function-like macro 'SETADDRESS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:104:44: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:105:58: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:109:5: error: constructor does not initialize these fields: mTree [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:91: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:112: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:210:88: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:210:109: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:322:87: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:322:108: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:362:20: error: variable 'file' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:363:22: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
ALICE3/Tasks/alice3-dilepton.cxx:53:8: error: constructor does not initialize these fields: inspdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 39 -gt 0 ]]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for bede0e2 at 2026-09-07 09:21:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera merged commit 6fa5252 into AliceO2Group:master Sep 9, 2026
11 of 14 checks passed
@vkucera
vkucera deleted the iwyu-ALICE3 branch September 9, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants