[ALICE3] Add short-lived particle table to otf tof pid by jesgum · Pull Request #17756 · AliceO2Group/O2Physics

jesgum · 2026-09-03T15:00:14Z

@njacazio please have a look :-)

github-actions · 2026-09-03T15:00:33Z

O2 linter results: ❌ 2 errors, ⚠️ 0 warnings, 🔕 0 disabled

njacazio

Very good!

njacazio · 2026-09-03T15:10:48Z

                  upgrade_tof::OuterTOFExpectedTimeHe3,
                  upgrade_tof::OuterTOFExpectedTimeAl);

+DECLARE_SOA_TABLE(UpgradeTofExtras, "AOD", "UPGRADETOFEXTRAS",


I'm not a fan of the naming actually, could we write that it has to do with long lived particles?

I renamed the table, in principle I think we could probably instead also split it to nsigma/times like the other ones but considering that the table is rather small right now we could keep it like this. I didn't start preparing the task that is supposed to use the table so if we want to change it later it shouldn't really be an issue

Please consider the following formatting changes to AliceO2Group#17756

alibuild · 2026-09-03T15:19:58Z

Error while checking build/O2Physics/code-check for 5fe6a55 at 2026-09-03 17:19:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 28 errors and 24 warnings.'
Found 28 errors and 24 warnings.
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/c633477a90bb1111d3d182052eae8b05194a7039/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:73:37: error: variable 'h2dInnerTimeResTrack' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:74:37: error: variable 'h2dInnerTimeResTotal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:75:37: error: variable 'h2dOuterTimeResTrack' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:76:37: error: variable 'h2dOuterTimeResTotal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:77:52: error: variable 'h2dInnerNsigmaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:78:52: error: variable 'h2dOuterNsigmaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:79:52: error: variable 'h2dInnerDeltaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:80:52: error: variable 'h2dOuterDeltaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:82:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:193:17: error: no header providing "std::find" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:217:27: error: unused local variable 'histPath' of type 'const std::string' (aka 'const basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:292:182: error: no header providing "o2::constants::math::TwoPI" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:350:17: error: member 'layerRadius' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:351:17: error: member 'layerLength' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:352:17: error: member 'pixelDimensionZ' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:353:17: error: member 'pixelDimensionRPhi' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:354:17: error: member 'fractionInactive' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:355:17: error: member 'magField' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:389:7: error: 'axisZ' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:399:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:404:35: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:458:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:465:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:485:13: error: variable 'x' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:485:16: error: variable 'y' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:485:19: error: variable 'z' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:490:12: error: variable 'b' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:773:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/c633477a90bb1111d3d182052eae8b05194a7039/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:68:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:175:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:176:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:177:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:178:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:179:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:180:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:181:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:182:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:183:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:184:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:185:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
[0 more errors; see full log]

Full log here.

alibuild · 2026-09-03T16:45:59Z

Error while checking build/O2Physics/code-check for 6a4b297 at 2026-09-03 18:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 28 errors and 24 warnings.'
Found 28 errors and 24 warnings.
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/62e677b489e3dace06c3a356d08af00301aeca1c/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:73:37: error: variable 'h2dInnerTimeResTrack' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:74:37: error: variable 'h2dInnerTimeResTotal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:75:37: error: variable 'h2dOuterTimeResTrack' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:76:37: error: variable 'h2dOuterTimeResTotal' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:77:52: error: variable 'h2dInnerNsigmaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:78:52: error: variable 'h2dOuterNsigmaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:79:52: error: variable 'h2dInnerDeltaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:80:52: error: variable 'h2dOuterDeltaTrue' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:82:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:193:17: error: no header providing "std::find" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:217:27: error: unused local variable 'histPath' of type 'const std::string' (aka 'const basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:292:182: error: no header providing "o2::constants::math::TwoPI" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:350:17: error: member 'layerRadius' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:351:17: error: member 'layerLength' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:352:17: error: member 'pixelDimensionZ' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:353:17: error: member 'pixelDimensionRPhi' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:354:17: error: member 'fractionInactive' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:355:17: error: member 'magField' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:389:7: error: 'axisZ' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:399:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:404:35: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:458:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:465:7: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:485:13: error: variable 'x' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:485:16: error: variable 'y' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:485:19: error: variable 'z' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:490:12: error: variable 'b' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:773:7: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/62e677b489e3dace06c3a356d08af00301aeca1c/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:68:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:175:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:176:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:177:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:178:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:179:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:180:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:181:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:182:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:183:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:184:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx:185:5: warning: use designated initializer list to initialize 'ParticleInfo' [modernize-use-designated-initializers]
[0 more errors; see full log]

Full log here.

njacazio · 2026-09-03T17:05:44Z

Warnings and friends to be fixed in a coming pr not to pollute this one

Add short lived particles tables to otf tof pid

5fe6a55

jesgum requested review from alibuild, hscheid and njacazio as code owners September 3, 2026 15:00

github-actions Bot added alice3 datamodel labels Sep 3, 2026

github-actions Bot changed the title ~~Add short lived particles tables to otf tof pid~~ [ALICE3] Add short lived particles tables to otf tof pid Sep 3, 2026

jesgum changed the title ~~[ALICE3] Add short lived particles tables to otf tof pid~~ [ALICE3] Add short-lived particle table to otf tof pid Sep 3, 2026

njacazio previously approved these changes Sep 3, 2026

View reviewed changes

Refactor particle types and update related logic

37c0710

njacazio dismissed their stale review via 37c0710 September 3, 2026 15:09

njacazio reviewed Sep 3, 2026

View reviewed changes

jesgum and others added 2 commits September 3, 2026 17:17

Update table name

e05a7d7

Please consider the following formatting changes

7460686

alibuild mentioned this pull request Sep 3, 2026

Please consider the following formatting changes to #17756 jesgum/O2Physics#30

Merged

Merge pull request #30 from alibuild/alibot-cleanup-17756

6a4b297

Please consider the following formatting changes to AliceO2Group#17756

njacazio approved these changes Sep 3, 2026

View reviewed changes

njacazio enabled auto-merge (squash) September 3, 2026 15:39

njacazio merged commit 7b07cdd into AliceO2Group:master Sep 3, 2026
13 of 16 checks passed

jesgum deleted the otf-tof-pid branch September 3, 2026 19:57

Navigation Menu

Uh oh!

[ALICE3] Add short-lived particle table to otf tof pid - #17756

[ALICE3] Add short-lived particle table to otf tof pid#17756
njacazio merged 5 commits into
AliceO2Group:masterfrom
jesgum:otf-tof-pid

jesgum commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

njacazio left a comment

Uh oh!

njacazio Sep 3, 2026

Uh oh!

jesgum Sep 3, 2026

Uh oh!

alibuild commented Sep 3, 2026

Uh oh!

Uh oh!

alibuild commented Sep 3, 2026

Uh oh!

njacazio commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jesgum commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

njacazio left a comment

Choose a reason for hiding this comment

Uh oh!

njacazio Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

jesgum Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

alibuild commented Sep 3, 2026

Uh oh!

Uh oh!

alibuild commented Sep 3, 2026

Uh oh!

njacazio commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants