Skip to content

[PWGLF] Update TOF calculation for wrong PID hypothesis in strangenesstofpid - #17749

Merged
romainschotter merged 6 commits into
AliceO2Group:masterfrom
romainschotter:fix-strangenesstofpid-v2
Sep 3, 2026
Merged

[PWGLF] Update TOF calculation for wrong PID hypothesis in strangenesstofpid#17749
romainschotter merged 6 commits into
AliceO2Group:masterfrom
romainschotter:fix-strangenesstofpid-v2

Conversation

@romainschotter

@romainschotter romainschotter commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator
  • remove unnecessary event time map
  • update TOF calculation for wrong PID hypothesis
  • adapt data model for storing all wrong PID hypothesis
  • use centralized TOF calibration in derived data

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 105 errors, ⚠️ 53 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Update TOF calculation for wrong PID hypothesis in strangenesstofpid [PWGLF] Update TOF calculation for wrong PID hypothesis in strangenesstofpid Sep 3, 2026
@alibuild alibuild mentioned this pull request Sep 3, 2026
Merged
@romainschotter
Merge pull request #86 from alibuild/alibot-cleanup-17749
b07f7ee 
Please consider the following formatting changes to AliceO2Group#17749
@alibuild alibuild mentioned this pull request Sep 3, 2026
Closed
@romainschotter
romainschotter marked this pull request as ready for review September 3, 2026 11:50
@romainschotter
romainschotter enabled auto-merge (squash) September 3, 2026 11:50
alibuild
alibuild approved these changes Sep 3, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@romainschotter
romainschotter merged commit 37e9336 into AliceO2Group:master Sep 3, 2026
12 of 15 checks passed
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c9d30b7 at 2026-09-03 17:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 60 errors and 44 warnings.'
Found 60 errors and 44 warnings.
++ [[ 60 -gt 0 ]]
++ cat /sw/BUILD/ace08ed5079fa20f995d17a85e11fba6c0dc4c90/O2Physics-code-check/errors.txt
PWGLF/DataModel/LFStrangenessPIDTables.h:61:32: error: casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include <cmath>) instead [bugprone-incorrect-roundings,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:70:1: error: included header unordered_map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:91:8: error: constructor does not initialize these fields: ccdb, mTOFResponse, nSigmaCalibLoaded [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:221:18: error: member 'bcShiftValuePS' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:281:5: error: uninitialized record type: 'mom' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:284:5: error: uninitialized record type: 'startPoint' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:293:11: error: variable 'sna' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:293:16: error: variable 'csa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:676:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:677:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:678:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:679:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:680:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:681:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:683:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:684:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:685:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:686:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:687:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:688:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:708:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:709:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:710:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:711:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:712:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:713:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:714:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:715:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:716:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:717:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:719:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:720:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:721:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:722:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:723:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:724:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:725:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:726:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:727:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:728:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:945:11: error: variable 'velocityPositiveEl' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:945:31: error: variable 'velocityPositivePr' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romainschotter @alibuild