Skip to content

[PWGDQ] various improvements to the global alignment task histograms - #17743

Draft
aferrero2707 wants to merge 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-dimuon-decay-length-plots
Draft

[PWGDQ] various improvements to the global alignment task histograms#17743
aferrero2707 wants to merge 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-dimuon-decay-length-plots

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor
  • added histograms for di-muon decay lengths
  • added possibility to modify some of the histogram axis definitions via configurable options
  • added option that reduces the size of MFT DCA histograms (enabled by default)

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 68 warnings, 🔕 5 disabled

* added histograms for di-muon decay lengths
* added possibility to modify some of the histogram axis definitions
  via configurable options
* added option that reduces the size of MFT DCA histograms (enabled by default)
mguilbau
mguilbau previously approved these changes Sep 3, 2026
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-decay-length-plots branch from f62a2c8 to 8ee1ec8 Compare September 3, 2026 08:23
@aferrero2707
aferrero2707 marked this pull request as ready for review September 3, 2026 08:29
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8ee1ec8 at 2026-09-03 15:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 0 warnings.'
Found 10 errors and 0 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/3f3c338eb856de4cb9699b61fdbfdaed2a162484/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:59:1: error: included header Vector3D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:60:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:313:18: error: no header providing "o2::vertexing::FwdDCAFitterN" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:354:10: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:361:10: error: no header providing "std::stringstream" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:366:7: error: empty catch statements hide issues; to handle exceptions appropriately, consider re-throwing, handling, or avoiding catch altogether [bugprone-empty-catch,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1213:12: error: slicing object from type 'GlobalFwdTrack' to 'TrackParCovFwd' discards 40 bytes of state [cppcoreguidelines-slicing,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1649:15: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1668:17: error: no header providing "ROOT::Math::XYZVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1687:8: error: no header providing "std::optional" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

@aferrero2707
aferrero2707 marked this pull request as draft September 3, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants