Skip to content

[PWGLF] Add new propagation method in forwardlambdakzeroanalysis - #17738

Merged
romainschotter merged 4 commits into
AliceO2Group:masterfrom
romainschotter:mft-v0s
Sep 3, 2026
Merged

[PWGLF] Add new propagation method in forwardlambdakzeroanalysis#17738
romainschotter merged 4 commits into
AliceO2Group:masterfrom
romainschotter:mft-v0s

Conversation

@romainschotter

@romainschotter romainschotter commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator
  • add new propagation method, closer to what is currently used for propagating MFT tracks to PV
  • fix axes used in DCA QA histograms

Thank you very much @MauriceCoke !

Refactor includes and improve propagation methods for vertex analysis.
@github-actions github-actions Bot added the pwglf label Sep 2, 2026
@github-actions github-actions Bot changed the title Add new propagation method [PWGLF] Add new propagation method Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 17 warnings, 🔕 0 disabled

@romainschotter romainschotter changed the title [PWGLF] Add new propagation method [PWGLF] Add new propagation method in forwardlambdakzeroanalysis Sep 2, 2026
@romainschotter
romainschotter marked this pull request as ready for review September 2, 2026 20:16
@romainschotter
romainschotter enabled auto-merge (squash) September 2, 2026 20:20

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6fe8f86 at 2026-09-03 01:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 70 warnings.'
Found 4 errors and 70 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/0753e5c3dccd61cbd2515cad7695aa0fdfa19a3c/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:91:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:92:9: error: function-like macro 'BITCHECK' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:191:67: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1221:91: error: no header providing "o2::track::DefaultDCA" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 70 -gt 0 ]]
++ cat /sw/BUILD/0753e5c3dccd61cbd2515cad7695aa0fdfa19a3c/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:162:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:384:5: warning: function 'positivePt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:385:5: warning: function 'negativePt' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:386:5: warning: function 'positivePz' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:387:5: warning: function 'negativePz' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:388:5: warning: function 'positivePtMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:389:5: warning: function 'negativePtMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:390:5: warning: function 'positivePzMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:391:5: warning: function 'negativePzMc' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:726:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:728:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:730:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:732:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:734:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1361:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1366:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1371:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1376:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1381:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1495:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1497:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1499:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1501:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1562:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1564:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1566:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1568:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1628:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1630:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1632:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1634:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1694:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1696:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1698:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1700:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/forwardlambdakzeroanalysis.cxx:1760:26: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit 6eddcef into AliceO2Group:master Sep 3, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants