Skip to content

[Common,PWGLF] Add forward compatibility with the new propagation-service-v2 - #17725

Open
ktf wants to merge 1 commit into
AliceO2Group:masterfrom
ktf:pr17725
Open

[Common,PWGLF] Add forward compatibility with the new propagation-service-v2#17725
ktf wants to merge 1 commit into
AliceO2Group:masterfrom
ktf:pr17725

Conversation

@ktf

@ktf ktf commented Sep 2, 2026

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 61 errors, ⚠️ 58 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add forward compatibility with the new propagation-service-v2 [Common,PWGLF] Add forward compatibility with the new propagation-service-v2 Sep 2, 2026
@ktf ktf changed the title [Common,PWGLF] Add forward compatibility with the new propagation-service-v2 Add forward compatibility with the new propagation-service-v2 Sep 2, 2026
@github-actions github-actions Bot changed the title Add forward compatibility with the new propagation-service-v2 [Common,PWGLF] Add forward compatibility with the new propagation-service-v2 Sep 2, 2026
@ktf ktf changed the title [Common,PWGLF] Add forward compatibility with the new propagation-service-v2 Add forward compatibility with the new propagation-service-v2 Sep 2, 2026
@github-actions github-actions Bot changed the title Add forward compatibility with the new propagation-service-v2 [Common,PWGLF] Add forward compatibility with the new propagation-service-v2 Sep 2, 2026
@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5f2d56a at 2026-09-03 15:32:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 23 errors and 68 warnings.'
Found 23 errors and 68 warnings.
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/22e47d54d3ce6894ac6c314cf8e0cf53a830415d/O2Physics-code-check/errors.txt
Common/Core/TPCVDriftManager.h:111:11: error: variable 'tTB' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Core/TPCVDriftManager.h:111:16: error: variable 'tTBErr' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Core/TPCVDriftManager.h:115:7: error: uninitialized record type: 'enc' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/Core/TPCVDriftManager.h:116:20: error: do not access members of unions; consider using (boost::)variant instead [cppcoreguidelines-pro-type-union-access,-warnings-as-errors]
Common/Tools/TrackTuner.h:392:19: error: the variable 'str' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
Common/Tools/TrackTuner.h:599:17: error: unused local variable 'grOneOverPtPionNameMC' of type 'std::string' (aka 'basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
Common/Tools/TrackTuner.h:600:17: error: unused local variable 'grOneOverPtPionNameData' of type 'std::string' (aka 'basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
Common/Tools/TrackTuner.h:629:50: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
Common/Tools/TrackTuner.h:762:18: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:60:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:322:80: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:408:85: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:419:95: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:423:91: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:424:99: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:425:91: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:426:91: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:453:3: error: constructor does not initialize these fields: mRunNumber [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:558:10: error: constructor does not initialize these fields: xyz, posP, negP, momentum [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:577:10: error: constructor does not initialize these fields: label, motherLabel, mcCollision, pdgCode, pdgCodeMother, pdgCodeV0, pdgCodePositive, pdgCodeNegative, pdgCodeBachelor, isPhysicalPrimary, xyz, lxyz, posP, negP, bachP, momentum, mcParticlePositive, mcParticleNegative, mcParticleBachelor [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:1708:11: error: uninitialized record type: 'positivePositionIU' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:1709:11: error: uninitialized record type: 'negativePositionIU' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Utils/strangenessBuilderModule.h:2768:7: error: uninitialized record type: 'dcaInfo' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 68 -gt 0 ]]
++ cat /sw/BUILD/22e47d54d3ce6894ac6c314cf8e0cf53a830415d/O2Physics-code-check/warnings.txt
Common/Tools/TrackPropagationModule.h:59:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Common/Tools/TrackPropagationModule.h:89:3: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
Common/Tools/TrackPropagationModule.h:164:17: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackPropagationModule.h:319:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Common/Tools/TrackTuner.h:88:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:89:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:90:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:91:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:102:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:373:40: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:402:12: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/TrackTuner.h:404:19: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/TrackTuner.h:415:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:420:53: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:424:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:428:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:432:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 5f2d56a at 2026-09-04 00:20:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants