Skip to content

Adapt o2dpg_sim_workflow.py to new TPC corr.maps - #2451

Open
shahor02 wants to merge 1 commit into
AliceO2Group:masterfrom
shahor02:pr_newtpcsc
Open

Adapt o2dpg_sim_workflow.py to new TPC corr.maps#2451
shahor02 wants to merge 1 commit into
AliceO2Group:masterfrom
shahor02:pr_newtpcsc

Conversation

@shahor02

@shahor02 shahor02 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Given that the new maps are provided by the tpc-scaler device and the latter is added in the MC by the o2-tpc-reco workflow, the corrections and CTP input request should be disable when the o2-tpc-reco is used for clusterization only (correction not used). In general, all settings of o2-tpc-scaler from the anchoring workflowconfig.log should be added to options of all MC reco workflows requiring TPC corrections (except the MC-specific settings like imposing --lumi-type 1 --corrmap-lumi-mode 2), but since at the moment MC does not simulate sector edge fluctuations, we simply add --disable-sec-edge-fluc-correction.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel

sawenzel commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

I verified the clusterization part on async-2026-PbPb-apass1-v7: I reproduce the
No matching output found for CTP/LUMI/0 fatal there, and --corrmap-lumi-mode 3 --disable-ctp-lumi-request fix it, with no effect on the older tags I tried. LGTM for that.

I see that no async tag supports --disable-sec-edge-fluc-correction yet, so we need to
query its availability via option_if_available:

tpc_corr_scaling_options += option_if_available('o2-tpc-reco-workflow', '--disable-sec-edge-fluc-correction', envfile=async_envfile)

Given that the new maps are provided by the tpc-scaler device and the latter is added in the MC
by the o2-tpc-reco workflow, the corrections and CTP input request should be disable when the
o2-tpc-reco is used for clusterization only (correction not used).
In general, all settings of o2-tpc-scaler from the anchoring workflowconfig.log should be
added to options of all MC reco workflows requiring TPC corrections (except the MC-specific
settings like imposing --lumi-type 1 --corrmap-lumi-mode 2), but since at the moment MC does
not simulate sector edge fluctuations, we simply add --disable-sec-edge-fluc-correction.
@shahor02

shahor02 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for spotting, indeed, I was testing with O2 dev. Added option_if_available...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants