Skip to content

Keep the ZEM geometry instead of skipping the whole ZDC module - #2449

Open
sawenzel wants to merge 1 commit into
AliceO2Group:masterfrom
sawenzel:zdc-zem-no-beamline
Open

Keep the ZEM geometry instead of skipping the whole ZDC module#2449
sawenzel wants to merge 1 commit into
AliceO2Group:masterfrom
sawenzel:zdc-zem-no-beamline

Conversation

@sawenzel

@sawenzel sawenzel commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This changes the simulation default from skipping the ZDC module to dropping only its +-113 m beam line, so the ZEM material stays in the transport geometry.

  • The ZDC geometry is the +-113 m beam line, its magnets, ZN, ZP and ZEM; the transport cost is the beam line, while ZEM sits at z = 7.6 m.
  • ZEM carries 217 kg of material between z = 745 and 862 cm, spanning eta 2.8 to 5.6, which is inside the FIT and FDD acceptance.
  • --skipModules no longer defaults to ZDC; create_geant_config() sets ZDCSimParam.buildBeamLine=false instead, unless --with-ZDC is given.
  • An explicit --skipModules ZDC still removes the module altogether.
  • ZDC stays out of digitisation and reconstruction as before, which the existing deactivate_detector('ZDC') already handles.
  • The MODULES variable removed from the two anchor scripts was never referenced; it read as if anchored MC opted out of ZDC, which the workflow default decided.
  • Requires ZDCSimParam.buildBeamLine in AliceO2.

https://its.cern.ch/jira/browse/O2-7158

This changes the simulation default from skipping the ZDC module to dropping only
its +-113 m beam line, so the ZEM material stays in the transport geometry.

- The ZDC geometry is the +-113 m beam line, its magnets, ZN, ZP and ZEM; the
  transport cost is the beam line, while ZEM sits at z = 7.6 m.
- ZEM carries 217 kg of material between z = 745 and 862 cm, spanning
  eta 2.8 to 5.6, which is inside the FIT and FDD acceptance.
- --skipModules no longer defaults to ZDC; create_geant_config() sets
  ZDCSimParam.buildBeamLine=false instead, unless --with-ZDC is given.
- An explicit --skipModules ZDC still removes the module altogether.
- ZDC stays out of digitisation and reconstruction as before, which the existing
  deactivate_detector('ZDC') already handles.
- The MODULES variable removed from the two anchor scripts was never referenced;
  it read as if anchored MC opted out of ZDC, which the workflow default decided.
- Requires ZDCSimParam.buildBeamLine in AliceO2.

https://its.cern.ch/jira/browse/O2-7158

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sawenzel
sawenzel requested a review from jackal1-66 as a code owner September 2, 2026 12:32
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel

sawenzel commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Needs AliceO2Group/AliceO2#15752 be merged beforehand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant