Skip to content

Add protection against skipped loopers #15755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Sep 4, 2026
+8 −2
Merged

Add protection against skipped loopers #15755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Generators/src/Generator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,20 +248,26 @@ Bool_t
LOG(error) << "Failed to generate loopers event";
return kFALSE;
}
if (mTPCLoopersGen->getNLoopers() == 0) {
const auto nCandidates = mTPCLoopersGen->getNLoopers();
if (nCandidates == 0) {
LOG(warning) << "No loopers generated for this event";
return kTRUE;
}
const auto& looperParticles = mTPCLoopersGen->importParticles();
const auto skippedLoopers = mTPCLoopersGen->getNSkipped();
if (looperParticles.empty()) {
if (skippedLoopers == nCandidates) {
// all candidate loopers were dropped by the geometrical protection
LOG(debug) << "All " << skippedLoopers << " candidate loopers were outside the TPC active volume; none added for this event";
return kTRUE;
}
LOG(error) << "Failed to import loopers particles";
return kFALSE;
}
// Append the generated looper particles to the main particle list
mParticles.insert(mParticles.end(), looperParticles.begin(), looperParticles.end());

LOG(debug) << "Added " << looperParticles.size() << " looper particles";
const auto skippedLoopers = mTPCLoopersGen->getNSkipped();
if (skippedLoopers > 0) {
LOG(debug) << "Geometrical protection skipped " << skippedLoopers << " loopers outside the TPC active volume";
}
Expand Down