TPC: move disable-IDC-scalers to CorrectionMapsOptions - #15754
Open
matthias-kleiner wants to merge 2 commits into
Open
TPC: move disable-IDC-scalers to CorrectionMapsOptions#15754matthias-kleiner wants to merge 2 commits into
matthias-kleiner wants to merge 2 commits into
Conversation
matthias-kleiner
requested review from
davidrohr,
sgorbuno,
shahor02 and
wiechula
as code owners
September 3, 2026 11:04
shahor02
reviewed
Sep 3, 2026
| const auto enableMShape = configcontext.options().get<bool>("enable-M-shape-correction"); | ||
| const auto enableIDCs = !configcontext.options().get<bool>("disable-IDC-scalers"); | ||
| specs.emplace_back(o2::tpc::getTPCScalerSpec(enableIDCs, enableMShape, sclOpt)); | ||
| specs.emplace_back(o2::tpc::getTPCScalerSpec(sclOpt.enableIDCScalers, sclOpt.enableMShapeCorrection, sclOpt)); |
Collaborator
There was a problem hiding this comment.
Thanks! Any reason for keeping enableIDCScalers and enableMShapeCorrection as separate arguments of getTPCScalerSpec, instead of calling directly getTPCScalerSpec(sclOpt) ?
Contributor
Author
There was a problem hiding this comment.
I think you are right, so in principle we could just automatically disable the IDCs like we do already in other places like Detectors/Align/Workflow/src/barrel-alignment-workflow.cxx in case we dont use the IDCs for scaling or? This should make it alot easier I assume
Unify getTPCScalerSpec() across all 13 call sites to take just CorrectionMapsGloOpts and derive enableIDCs/enableMShape internally, instead of passing them as separate bools. This removes the disable-IDC-scalers CLI flag and enableIDCScalers field added in the previous commit: tpc-scaler.cxx/tpc-refitter-workflow.cxx now derive enableIDCs the same way as every other caller already did (sclOpts.lumiType == LumiScaleType::TPCScaler), instead of a separate manual override. dpl-workflow.sh's parse_TPC_CORR_SCALING() previously hand-replicated this exact lumiType==TPCScaler logic externally (IGNOREIDC) just to synthesize --disable-IDC-scalers for o2-tpc-scaler-workflow; that workaround is now unnecessary and removed.
matthias-kleiner
requested review from
a team,
bazinski,
f3sch and
wille10
as code owners
September 3, 2026 11:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.