Skip to content

Fix out-of-range hit access in the TOF hit merging #15747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Sep 2, 2026
+3 −1
Merged

Fix out-of-range hit access in the TOF hit merging #15747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Detectors/TOF/simulation/src/Detector.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ Bool_t Detector::ProcessHits(FairVolume* v)
Geo::getPadDxDyDz(pos, det, delta);
auto channel = Geo::getIndex(det);
HitType newhit(posx, posy, posz, time, enDep, trackID, sensID);
if (channel != mLastChannelID || !isMergable(newhit, mHits->back())) {
// an invalid channel (getIndex returns -1 off a valid pad) never merges, and
// there is nothing to merge with before the first hit of the event
if (channel < 0 || mHits->empty() || channel != mLastChannelID || !isMergable(newhit, mHits->back())) {
mHits->push_back(newhit);
stack->addHit(GetDetId());
} else {
Expand Down
Loading