Keep the libcurl header out of CcdbApi.h - #15745
Open
sawenzel wants to merge 2 commits into
Open
Conversation
Moves the libcurl dependency out of the public `CcdbApi.h` header and keeps it in the implementation where it belongs. This makes the header self-contained and allows ROOT to interpret it without requiring the curl headers.
sawenzel
requested review from
a team,
Barthelemy and
costing
as code owners
September 1, 2026 10:43
Barthelemy
approved these changes
Sep 1, 2026
Barthelemy
left a comment
Collaborator
There was a problem hiding this comment.
this is great, thanks !
ktf
approved these changes
Sep 1, 2026
costing
approved these changes
Sep 1, 2026
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 10df9ff at 2026-09-01 15:33: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the libcurl dependency out of the public
CcdbApi.hheader and keeps it in the implementation where it belongs. This makes the header self-contained and allows ROOT to interpret it without requiring the curl headers.