Repository navigation
Ensure transcript type is a single value or comma separated string - #345
Merged
Merged
Conversation
Member
Author
|
@jashapiro I made a small change in 374d863 to pass tests and account for the case where there is no |
jashapiro
approved these changes
Oct 30, 2026
jashapiro
left a comment
jashapiro
left a comment
Member
There was a problem hiding this comment.
assuming tests pass, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to discussion in AlexsLemonade/scpca-nf#1372, this PR updates the
transcript_typethat is stored in the metadata of SCE objects to be a single character string rather than a vector. Anytime we had a vector with two values, I turned it into a comma separated string. This should ensure that no matter how many values are present the type in both SCE and AnnData objects will be consistent.The only actual changes here are the changes to
transcript_type <- "total,spliced"but because I opened this in an editor withairformatting, a bunch of formatting changes are also included.