Fix/ftp stale session - #367
Merged
Merged
Conversation
Large DATASUS transfers are throttled and dropped mid-stream; restarting them from zero on every retry meant they could never finish. Resume from the partial file via REST (retrbinary rest=), keep FTP partials between retries, and stop abandoning the worker thread so a stalled transfer is joined before the session is reset.
The resume guard compared the client origin to lowercase "ftp", but the FTP client reports "FTP", so every retry deleted the partial and the download restarted from zero — defeats REST resume for large files.
_retr_with_resume now calls retrbinary(..., rest=...) and reads ftp.size(); update the two mocks that predate it.
luabida
marked this pull request as ready for review
October 2, 2026 16:02
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage ? 97.19%
=======================================
Files ? 180
Lines ? 22998
Branches ? 0
=======================================
Hits ? 22354
Misses ? 644
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 2.11.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.