fix(cli): make pysus ftp files and download work

[devgtv]

Summary

Both commands called the async FTP client without awaiting it, used a method that doesn't exist, never connected, and never wrote any file:

ftp = _get_ftp()
try:
    datasets = ftp.datasets()          # async def — coroutine, never awaited
    ...
    remote_files = target.get_files()  # AttributeError: no such method
    ...
    ftp.download(f, out_dir)           # async def — coroutine, never awaited
finally:
    ftp.close()                        # async def — coroutine, never awaited

connect, datasets, download and close are all async def in pysus/api/ftp/client.py. Datasets expose their files through the content/search contract (BaseRemoteDataset), not get_files() — which appears nowhere else in the codebase. connect() was also never called, and datasets() itself raises ConnectionError when the client is not connected.

Impact

• pysus ftp files SINAN → TypeError: 'coroutine' object is not iterable
• pysus ftp download SINAN → printed Downloading 3 file(s)... and Done. Files saved to ... with exit code 0, having written zero bytes

Two of the command's four behaviors were entirely non-functional, and the download path reported false success.

Fix

• Both commands now run inside an async helper driven by _run_sync, the same bridge the dadosgov CLI uses (so they also work under Jupyter, where asyncio.run would fail)
• await ftp.connect() opens the session; await ftp.close() runs in finally
• get_files() → await target.search(), which recurses through groups to the files
• filters compare against str(f.path) so a non-str path cannot raise
• download awaits each transfer and writes out_dir / <basename> rather than handing the full remote path to open()
• the duplicated filter block moved into a shared _select_files, and the class-name lookup into _resolve_dataset

Tests

The existing test_ftp.py only covered the bad-slug path, so nothing ever reached these lines. Added 7 tests with a fake async client covering: listing files, the --year filter, no-match exiting 0, close() on error, all 3 transfers being awaited, writing basenames rather than full remote paths, and no false "Done." on no-match.

Verified all 7 fail against the previous code (TypeError: 'coroutine' object is not iterable plus coroutine ... was never awaited warnings).

• 1740 passed, 6 skipped
• black and isort clean

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.82353% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@9db5915). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pysus/tests/cli/test_ftp.py	98.82%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage        ?   97.21%           
=======================================
  Files           ?      180           
  Lines           ?    23371           
  Branches        ?        0           
=======================================
  Hits            ?    22721           
  Misses          ?      650           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.