Skip to content

Add Aikido Code Coverage - #355

Open
mattgek wants to merge 1 commit into
mainfrom
add-aikido-code-cov
Open

Add Aikido Code Coverage#355
mattgek wants to merge 1 commit into
mainfrom
add-aikido-code-cov

Conversation

@mattgek

@mattgek mattgek commented Sep 3, 2026

Copy link
Copy Markdown

No description provided.

Comment thread .github/workflows/gradle-tests.yml Outdated
Comment thread .github/workflows/gradle-tests.yml Outdated
Comment thread .github/workflows/gradle-tests.yml Outdated
@hansott
hansott force-pushed the add-aikido-code-cov branch from ee709c2 to 840b939 Compare September 8, 2026 15:43
Comment thread agent_api/build.gradle
@hansott
hansott force-pushed the add-aikido-code-cov branch from 840b939 to 3f73ec9 Compare September 8, 2026 15:47
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread Makefile Outdated
@hansott
hansott force-pushed the add-aikido-code-cov branch from 3f73ec9 to 15b29ae Compare September 8, 2026 16:11
@@ -2,8 +2,6 @@ name: 🧪 Unit Tests

on:
push:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium - All branch pushes now run credentialed coverage jobs

Removing the push branch filter makes this workflow execute its coverage paths for every branch push, not just the protected main branch. A user who can push a branch can therefore change the workflow on that branch and use the newly reachable id-token: write job or the Codecov step's repository token to exfiltrate credentials or mint a trusted OIDC identity, whereas the former main-only trigger prevented non-main branch workflows from reaching them. This expands the privileged workflow trust boundary to unprotected branches.

Suggested change
push:
push:
branches:
- main

More info - Reply on this comment to give feedback or ignore the issue.

Signed-off-by: matthiasgekiere <matthias.gekiere@codekt.be>
@hansott
hansott force-pushed the add-aikido-code-cov branch from 15b29ae to b9504ec Compare September 8, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants