Repository navigation
exposing network_los to annotator and preprocessor - #1134
Merged
jpn-- merged 1 commit intoOct 22, 2026
Merged
Conversation
jpn--
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1133
expressions.compute_columnsnow addsnetwork_losto the locals used to evaluate expressions, next toskim_dict, so preprocessor and annotate-table specs can callnetwork_los.skim_time_period_label(...)and readnetwork_los.skim_time_periods.NameError: name 'network_los' is not definedraised when atrip_mode_choiceannotate-trips spec usesnetwork_los.test_preprocessingpreprocessor spec gains alos_periodcolumn computed withnetwork_los.skim_time_period_label(df.depart), and the fixtures registernetwork_losand supply adepartcolumn.test_preprocessing.pypasses (2 passed).network_losobject available in expression files.