Repository navigation
Make the state publish meta data clearer to review and edit - #3868
Open
icanhasmath wants to merge 2 commits into
Open
icanhasmath wants to merge 2 commits into
icanhasmath wants to merge 2 commits into
Conversation
Follow-up to #3867 from testing the 0.48.2-RC2 build: - Without --namespace, a --build publish from a pyproject.toml now defaults to private/<org>/python (otherwise private/<org>, as before). - A new ingredient's namespace can be changed in the editor. It is checked like --namespace and put back, with the reason, if it can't be used. - The confirmation and editor say up front which fields can't be changed and why, and the error for changing one names it. - The preview and editor show plain yaml without a help comment on every field; the fields are described in the publish guide instead. The yaml-comment module is no longer used and is removed. - state export ingredient-meta now includes the ingredient's description. state publish --edit no longer refuses a different description on an existing version: it keeps the current one and says the change is ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
icanhasmath
force-pushed
the
marcg/0-48-2-RC2-namespace-edits
branch
from
October 28, 2026 23:38
9b12c5f to
11e5bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3867, from testing the 0.48.2-RC2 Windows build: changing the namespace in the
state publisheditor was refused, and nothing said in advance which fields were fixed.Changes
Default namespace: without
--namespace(or a namespace in the--metafile),state publish --buildnow usesprivate/<org>/pythonwhen the source directory has apyproject.toml. Otherwise it still usesprivate/<org>.Namespace edits: a new ingredient's namespace can now be changed in the editor.
--buildwrites the name and version into the package, but not the namespace. The new namespace gets the same checks as--namespace:--build, it must be under the project's organizationIf it fails a check, the previous namespace is put back, the user's other edits are kept, and the reason is shown. With
--editthe namespace still can't be changed, because it identifies the ingredient being revised.Fixed fields stated up front: with
--buildor--edit, the confirmation prompt and the editor notice say which fields can't be changed and why. If one is changed anyway, the error names that field (e.g. "The name can't be changed at this point, because it was already built into the package") instead of "name, namespace or version".No help comments in the meta data: the confirmation preview and the editor no longer show a comment on every field (
# The name of the ingredient, ...). They now show the same plain yaml as saved meta files andstate export ingredient-meta. The fields are described in a table in the publish guide instead. Theyaml-commentmodule, andmaruel/naturalwhich only it used, are removed fromgo.modandvendor/.Description in export and
--edit:state export ingredient-metaleft the description empty, although it is published. The description belongs to the ingredient, not the version, so export now fetches it from there.state publish --editno longer refuses a description that differs on an existing version. The confirmation shows the current description and says the change is ignored, and the other edits can still be published. The description is still left out of the request for a revision, because the platform rejects it.Testing
confirm_test.gocover the default namespace, a namespace edit that is kept, each check that puts the old namespace back, and the fixed-field errors for--buildand--edit. Tests also cover the preview having no comments, the exported description, and an ignored description change. Each test fails when its fix is reverted.🤖 Generated with Claude Code