Skip to content

fix(editor): treat missing write capability as editable - #2853

Merged
bajrangCoder merged 2 commits into
mainfrom
fix/github-plugin-files-readonly
Sep 3, 2026
Merged

fix(editor): treat missing write capability as editable#2853
bajrangCoder merged 2 commits into
mainfrom
fix/github-plugin-files-readonly

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR changes file-opening behavior so that only an explicit canWrite: false marks an editor as read-only.

  • Filesystem providers that omit write-capability metadata now open files as editable.
  • Explicitly non-writable files remain read-only.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or non-blocking defects identified in the changed behavior.

Current filesystem providers supply boolean write-capability values, explicit false remains read-only, and no reachable provider path was established where the new missing-capability behavior incorrectly enables editing.

Important Files Changed

Filename Overview
src/lib/openFile.js Replaces a general falsy check with an explicit false comparison, preserving read-only behavior for declared non-writable files while treating absent capability metadata as editable.

Reviews (1): Last reviewed commit: "fix(editor): treat missing write capabil..." | Re-trigger Greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit edb99ab Sep 3, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Sep 3, 2026
@bajrangCoder
bajrangCoder deleted the fix/github-plugin-files-readonly branch September 3, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants