Skip to content

fix(editor): improve selection contrast on active lines - #2852

Merged
bajrangCoder merged 1 commit into
mainfrom
fix/active-line-selection-contrast
Sep 3, 2026
Merged

fix(editor): improve selection contrast on active lines#2852
bajrangCoder merged 1 commit into
mainfrom
fix/active-line-selection-contrast

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes active-line backgrounds translucent in five dark editor-theme implementations so selections remain visible on the active line.

  • Updates all four Catppuccin variants through their shared configuration.
  • Adjusts Tokyo Night, Tomorrow Night, Tomorrow Night Bright, and VS Code Dark active-line colors.
  • Adds a unit test requiring configured active-line backgrounds to use translucent eight-digit hexadecimal colors.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete functional, security, or build failures identified.

The changed colors are valid CSS values, every currently registered theme satisfies the new translucency assertion, and the updated configurations preserve existing theme construction and rendering bindings.

Important Files Changed

Filename Overview
src/cm/themes/catppuccin.js Makes the shared active-line color translucent across all four Catppuccin variants; no actionable defect was identified.
src/cm/themes/tokyoNight.js Replaces the opaque active-line color with a valid translucent color while preserving the theme structure.
src/cm/themes/tomorrowNight.js Changes the active-line background to a translucent theme-compatible value.
src/cm/themes/tomorrowNightBright.js Changes the active-line background to a translucent value suitable for its black base.
src/cm/themes/vscodeDark.js Makes the active-line background translucent without changing selection or syntax colors.
tests/unit/editorThemes.test.js Adds a registry-wide assertion that every configured active-line background is an eight-digit hex color with nonopaque alpha.

Reviews (1): Last reviewed commit: "fix(editor): improve selection contrast ..." | Re-trigger Greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit aa62e83 Sep 3, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Sep 3, 2026
@bajrangCoder
bajrangCoder deleted the fix/active-line-selection-contrast branch September 3, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant