Repository navigation
fix: pin net10.0 DevTools to the lowest marketplace release 16.10.2902954 - #24
Merged
Merged
Conversation
…2954 The Analyzers CI compiles its cops against the lowest available SDK per TFM. That floor moves down whenever Microsoft publishes a build of a TFM for an older AL major. Microsoft now ships net10.0 VSIXes for AL 16.10 and 17.10, so the net10.0 floor dropped from 18.0.41.39415 to 16.10.44.19458. A RoslynTestKit lib compiled against 18.0.41.39415 fails consumer test builds on the 16.10/17.10 SDKs with CS1705, and the runtime refuses to bind a lower assembly version anyway. Pin net10.0 to VSIX 16.10.2902954 (SDK 16.10.44.19458), the same lowest-release convention as netstandard2.1 and net8.0. The 16.10 VSIX uses the legacy extension/bin/Analyzers layout, so the explicit path-in-archive override is dropped from both workflows. Document the pinning policy and the layout probe in the DevTools rules. +semver: patch Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Arthurvdv
force-pushed
the
fix/net10-devtools-lowest-marketplace
branch
from
October 20, 2026 10:23
7b47766 to
7e8bac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the net10.0 DevTools reference to the lowest net10.0 marketplace release, VSIX
16.10.2902954(SDK16.10.44.19458), instead of18.0.2726309(18.0.41.39415). Files changed: csproj comment, both workflows (version and removal of thepath-in-archiveoverride), CLAUDE.md DevTools table,.claude/rules/devtools-tfm.md(new "Which version to pin" section and layout-probe checklist item).Mechanism
The Analyzers CI compiles its cops against the lowest available SDK per TFM. That floor moves down whenever Microsoft publishes a build of a TFM for an older AL major. Net10.0 VSIXes now exist for AL 16.10 and 17.10, so the floor is 16.10.44.19458. A RoslynTestKit lib compiled against 18.0.41.39415 fails every consumer test leg between those versions with CS1705 (hard compiler error), and the runtime would refuse to bind a lower assembly version anyway. Compiling against the lowest release keeps the lib usable on all newer SDKs. The 16.10 VSIX uses the legacy
extension/bin/Analyzerslayout, so the explicitpath-in-archive: 'extension/bin'is removed (the action input stays for AL 18+).Verification
dotnet restoreanddotnet pack -c Releasesucceed; nupkg containslib/netstandard2.1,lib/net8.0,lib/net10.0RoslynTestKit.dll. net10.0 DLLs were fetched with the repo's three scripts from VSIX 16.10.2902954 (FileVersion 16.10.44.19458).origin/main, throwaway worktree, SDK folder with net10.0 = 16.10.44.19458):dotnet test ALCops.LinterCop.Testwith RoslynTestKit 1.5.0 fails with CS1705 (RoslynTestKit uses Nav.CodeAnalysis 18.0.41.39415, higher than the referenced 16.10). With the packed 1.5.1 package it passes: Passed 392, Failed 0, Skipped 4.Review notes
Release
Merging to
masterpublishesALCops.RoslynTestKit1.5.1 to NuGet.org and GitHub Packages (+semver: patch).🤖 Generated with Claude Code