Repository navigation
revert: fix(AC0032): count CalcSums as a read operation (#580) - #584
Merged
Merged
Conversation
This reverts commit 535330b. Runtime probes on BC 29 (Docker) and BC 28.5 (SaaS) showed CalcSums and CalcFields succeed with only the user's indirect permission, whether or not the calling object declares tabledata X = r, so the change would make AC0031 ask for permissions that have no effect. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #580 so the next release does not ship it.
Runtime probes on BC 29 (Docker) and BC 28.5 (SaaS) showed
CalcSumsandCalcFieldssucceed with only the user's indirect permission, whether or not the calling object declarestabledata X = r, also on tables the license limits to indirect access (findings on #578). With #580, AC0031 would ask for aPermissionsentry that has no runtime effect. After this revert, AC0031/AC0032 behave as in v1.3.1 forCalcSums.Plain revert of 535330b. Conflicts with #581 and #582 (adjacent lines in the AC0031/AC0032 rule docs,
record-method-classification.mdand both test classes) were resolved by removing only theCalcSumslines.Refs #578 (kept open pending the reporter's runtime repro)
Tests
dotnet test ALCops.sln: all greendotnet format ALCops.sln --verify-no-changes: cleanValidate-Rules.ps1: passesDocs PR: ALCops/alcops.dev#205
🤖 Generated with Claude Code