Repository navigation
Fix column-major ordering of multidimensional text waves - #29
Merged
paulmueller merged 1 commit intoOct 14, 2026
Merged
paulmueller merged 1 commit into
paulmueller merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25.
Text-wave strings are stored with the first dimension varying fastest. Reshape them in Fortran order, matching the numeric wave reader, so multidimensional coordinates are preserved.
Adds the reporter's
text3.ibwsample and a regression for its 3-by-2 layout, with fixture credit intests/data/README.Validation: all 18 tests pass from source and the installed wheel; repository flake8 passes.