fix: prevent truncated rollout mid-file on shutdown recovery - #201
Merged
wangtsiao merged 1 commit intoSep 8, 2026
Merged
Conversation
Cancel/abort the active turn before persisting recovery on shutdown, trim crash-tail bytes before append, and treat truncated+blank JSONL as final so restart hydration no longer fails closed on the queue-drain race. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shutdown, so concurrent journal writes cannot leave a truncated JSONL row behind later shutdown facts.queue_drains_after_restart_when_session_idleby dropping the runtime before unblocking the gated provider.Test plan
cargo test -p devo-server --lib queue_drains_after_restart_when_session_idlecargo test -p devo-server --lib hydration_tolerates_truncatedcargo test -p devo-server --lib load_tolerates_truncated_crash_tail