Skip to content

fix: hardcoded default Django SECRET_KEY allows offline forgery of signing-based tokens and unauthenticated file access #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Aug 28, 2026
+8 −3
Merged

fix: hardcoded default Django SECRET_KEY allows offline forgery of signing-based tokens and unauthenticated file access #6801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/maxkb/settings/base/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
# See https://docs.djangoproject.com/en/4.2/howto/deployment/checklist/

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = CONFIG.get("SECRET_KEY") or 'django-insecure-zm^1_^i5)3gp^&0io6zg72&z!a*d=9kf9o2%uft+27l)+t(#3e'

SECRET_KEY = CONFIG.get('SECRET_KEY')
if not SECRET_KEY:
raise RuntimeError(
"MAXKB_SECRET_KEY not configured, please provide it in the environment variable or configuration")
# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = CONFIG.get_debug()

Expand Down
5 changes: 4 additions & 1 deletion installer/start-maxkb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,8 @@ if [ -d $_INIT_SHELL_DIR ]; then
fi
done
fi

if [ -z "$MAXKB_SECRET_KEY" ]; then
MAXKB_SECRET_KEY=$(python -c 'from django.core.management.utils import get_random_secret_key; print(get_random_secret_key())')
fi
export MAXKB_SECRET_KEY
python /opt/maxkb-app/main.py start
Loading