Skip to content

Fixes bug where Framework Type was not being treated as optional data #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alail-ims merged 1 commit into from
Sep 16, 2026
Merged

Fixes bug where Framework Type was not being treated as optional data #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions apps/editor/src/ui/home/frameworkStore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { describe, it, expect } from 'vitest'
import { createNewFrameworkDraft } from './frameworkStore'

describe('createNewFrameworkDraft', () => {
it('leaves frameworkType undefined when not provided', () => {
const fw = createNewFrameworkDraft({ title: 'My framework' })
const frameworkNode = fw.graph?.nodes.find((n) => n.type === 'caseFrameworkNode') as
| { data: { cfDocument: { frameworkType?: string } } }
| undefined

expect(fw.framework.metadata?.frameworkType).toBeUndefined()
expect(fw.cfDocument.frameworkType).toBeUndefined()
expect(frameworkNode?.data.cfDocument.frameworkType).toBeUndefined()
})

it('preserves an explicit frameworkType when provided', () => {
const fw = createNewFrameworkDraft({ title: 'My framework', frameworkType: 'Higher Ed' })
const frameworkNode = fw.graph?.nodes.find((n) => n.type === 'caseFrameworkNode') as
| { data: { cfDocument: { frameworkType?: string } } }
| undefined

expect(fw.framework.metadata?.frameworkType).toBe('Higher Ed')
expect(fw.cfDocument.frameworkType).toBe('Higher Ed')
expect(frameworkNode?.data.cfDocument.frameworkType).toBe('Higher Ed')
})
})
4 changes: 2 additions & 2 deletions apps/editor/src/ui/home/frameworkStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export function createNewFrameworkDraft(params: CreateFrameworkDraft): HomeFrame
const framework = createFrameworkFromMetadata({
id,
title,
frameworkType: params.frameworkType ?? 'K-12',
frameworkType: params.frameworkType,
adoptionStatus: params.adoptionStatus ?? 'Draft',
description: params.description ?? '',
creator: 'District Curriculum Team',
Expand All @@ -215,7 +215,7 @@ export function createNewFrameworkDraft(params: CreateFrameworkDraft): HomeFrame
const graph = createEmptyFrameworkGraph({
id,
title,
frameworkType: params.frameworkType ?? 'K-12',
frameworkType: params.frameworkType,
adoptionStatus: params.adoptionStatus ?? 'Draft',
description: params.description ?? '',
creator: 'District Curriculum Team',
Expand Down
Loading