Repository navigation
Tidy up the workflows and the Gradle version handling - #124
Merged
Merged
Conversation
Dependabot updated the wrapper to 9.8.1 but not the gradleVersion property the wrapper task reads, so ./gradlew wrapper would have gone back to 9.7.1.
- Beta Release: patch the version after Setup Java/Gradle, so the first Gradle run uses Java 21, the Gradle cache and a validated wrapper - Pin jlumbroso/free-disk-space to v2.0.0 instead of main, tool-cache is called preinstalled-runtimes there - Release: drop the unused pull-requests: write permission - Drop the gradleVersion property and the wrapper configuration: Dependabot only updates gradle-wrapper.properties, so the property fell behind with every update
0verEngineer
changed the title
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.2.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups after #122 and a look over main:
gradleVersionproperty ingradle.properties, which thewrappertask read -./gradlew wrapperwould have downgraded the wrapper to 9.7.1 again, and that would repeat with every Dependabot update. The property and thewrapper { }configuration are gone,gradle/wrapper/gradle-wrapper.propertiesis the only place the version lives../gradlew wrappernow keeps the current version and leaves the wrapper files unchanged; to change it by hand:./gradlew wrapper --gradle-version <version>./gradlewbefore Setup Java and Setup Gradle, so on the runner's default JDK, without the Gradle cache and before the wrapper was validated. It now runs after bothv2.0.0instead ofmain, so a push there no longer runs in this CI unreviewed, and Dependabot keeps it up to date.tool-cacheis calledpreinstalled-runtimesin v2 (same default). v2 no longer removes the swap file by default; the other cleanups free far more space than thatpull-requests: writepermissionNo changelog entry, build and CI only.