A couple of weeks ago I made pull request for Home Asissant in order to add async support to the MaxCube module. However, it couldn't be accepted as the package itself is using sockets.
I've tried to think of ways to change this but since it is a fundamental change to the package, I first file an issue.
The documentateion states this module is meant to be used with HA and since asyncio is the preferred way now, it would make sense to simply rewrite it, but that might break things elsewhere. What is your view on this? Personally I do not have enough knowledge of the proprietary part to come up with a solution.
A couple of weeks ago I made pull request for Home Asissant in order to add async support to the MaxCube module. However, it couldn't be accepted as the package itself is using sockets.
I've tried to think of ways to change this but since it is a fundamental change to the package, I first file an issue.
The documentateion states this module is meant to be used with HA and since asyncio is the preferred way now, it would make sense to simply rewrite it, but that might break things elsewhere. What is your view on this? Personally I do not have enough knowledge of the proprietary part to come up with a solution.