From 6ace0d11f2998014d43af2d776b918bfda18ab06 Mon Sep 17 00:00:00 2001 From: CypherPotato Date: Mon, 9 Nov 2026 08:33:48 -0300 Subject: [PATCH 1/3] fix(file-server): do not write media body for HEAD requests --- .../Converters/HttpFileRangedContentStream.cs | 3 ++ .../Tests/BugFindingRegressionTests.cs | 40 +++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/src/Http/FileSystem/Converters/HttpFileRangedContentStream.cs b/src/Http/FileSystem/Converters/HttpFileRangedContentStream.cs index 308453b..a9fd8c5 100644 --- a/src/Http/FileSystem/Converters/HttpFileRangedContentStream.cs +++ b/src/Http/FileSystem/Converters/HttpFileRangedContentStream.cs @@ -48,6 +48,9 @@ out bool isRangeSatisfiable resStream.SetHeader ( HttpKnownHeaderNames.ContentType, MimeHelper.GetMimeType ( file.Extension ) ); resStream.SetContentLength ( length ); + if (request.Method == HttpMethod.Head) + return resStream.Close (); + var buffer = ArrayPool.Shared.Rent ( ChunkSize ); try { int read; diff --git a/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs b/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs index 3136da4..f051f63 100644 --- a/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs +++ b/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs @@ -8,6 +8,7 @@ // Repository: https://github.com/sisk-http/core using System.Net; +using System.Net.Sockets; using System.Text; using Sisk.Cadente.CoreEngine; using Sisk.Core.Entity; @@ -140,6 +141,45 @@ public async Task FileServerKeepsPlusSignInPath () { Assert.AreEqual ( "space", await client.GetStringAsync ( "static/a%20b.txt" ) ); } + [TestMethod] + [DataRow ( false )] + [DataRow ( true )] + public async Task FileServerHeadOnMediaFileDoesNotWriteBody ( bool cadente ) { + string root = Directory.CreateTempSubdirectory ( "sisk-file-head-" ).FullName; + File.WriteAllBytes ( Path.Combine ( root, "v.mp4" ), new byte [ 300_000 ] ); + File.WriteAllText ( Path.Combine ( root, "after.txt" ), "after" ); + + using var host = TestHost.Start ( + r => r.Map ( HttpFileServer.CreateServingRoute ( "/static", root ) ), + config => { + if (cadente) + config.Engine = new CadenteHttpServerEngine (); + } ); + + var baseUri = new Uri ( host.HttpServer.ListeningPrefixes [ 0 ] ); + using var cts = new CancellationTokenSource ( TimeSpan.FromSeconds ( 10 ) ); + using var tcp = new TcpClient (); + await tcp.ConnectAsync ( IPAddress.Loopback, baseUri.Port, cts.Token ); + await using var stream = tcp.GetStream (); + + await stream.WriteAsync ( Encoding.ASCII.GetBytes ( + $"HEAD /static/v.mp4 HTTP/1.1\r\nHost: {baseUri.Authority}\r\n\r\n" + + $"GET /static/after.txt HTTP/1.1\r\nHost: {baseUri.Authority}\r\nConnection: close\r\n\r\n" ), cts.Token ); + + using var received = new MemoryStream (); + await stream.CopyToAsync ( received, cts.Token ); + string raw = Encoding.Latin1.GetString ( received.ToArray () ); + + int headEnd = raw.IndexOf ( "\r\n\r\n", StringComparison.Ordinal ); + Assert.IsTrue ( headEnd > 0, raw ); + + string headHeaders = raw [ ..headEnd ]; + StringAssert.StartsWith ( headHeaders, "HTTP/1.1 200" ); + StringAssert.Contains ( headHeaders.ToLowerInvariant (), "content-length: 300000" ); + StringAssert.StartsWith ( raw [ (headEnd + 4).. ], "HTTP/1.1 200" ); + StringAssert.EndsWith ( raw, "after" ); + } + [TestMethod] [DataRow ( false, true )] [DataRow ( false, false )] From 2f8ac68b3d9f560f2c825c3a56981fa7ab85e819 Mon Sep 17 00:00:00 2001 From: CypherPotato Date: Thu, 12 Nov 2026 10:28:51 -0300 Subject: [PATCH 2/3] test(file-server): connect HEAD regression test to the listening host --- tests/Sisk.Core/Tests/BugFindingRegressionTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs b/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs index f051f63..a8ac3aa 100644 --- a/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs +++ b/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs @@ -159,7 +159,7 @@ public async Task FileServerHeadOnMediaFileDoesNotWriteBody ( bool cadente ) { var baseUri = new Uri ( host.HttpServer.ListeningPrefixes [ 0 ] ); using var cts = new CancellationTokenSource ( TimeSpan.FromSeconds ( 10 ) ); using var tcp = new TcpClient (); - await tcp.ConnectAsync ( IPAddress.Loopback, baseUri.Port, cts.Token ); + await tcp.ConnectAsync ( baseUri.Host, baseUri.Port, cts.Token ); await using var stream = tcp.GetStream (); await stream.WriteAsync ( Encoding.ASCII.GetBytes ( From e4d5ab8556a7d0340af9adb9f49dd90c15b7d661 Mon Sep 17 00:00:00 2001 From: CypherPotato Date: Thu, 12 Nov 2026 10:42:57 -0300 Subject: [PATCH 3/3] test(file-server): assert HEAD response has no body without pipelining --- tests/Sisk.Core/Tests/BugFindingRegressionTests.cs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs b/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs index a8ac3aa..cc19008 100644 --- a/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs +++ b/tests/Sisk.Core/Tests/BugFindingRegressionTests.cs @@ -147,7 +147,6 @@ public async Task FileServerKeepsPlusSignInPath () { public async Task FileServerHeadOnMediaFileDoesNotWriteBody ( bool cadente ) { string root = Directory.CreateTempSubdirectory ( "sisk-file-head-" ).FullName; File.WriteAllBytes ( Path.Combine ( root, "v.mp4" ), new byte [ 300_000 ] ); - File.WriteAllText ( Path.Combine ( root, "after.txt" ), "after" ); using var host = TestHost.Start ( r => r.Map ( HttpFileServer.CreateServingRoute ( "/static", root ) ), @@ -163,8 +162,7 @@ public async Task FileServerHeadOnMediaFileDoesNotWriteBody ( bool cadente ) { await using var stream = tcp.GetStream (); await stream.WriteAsync ( Encoding.ASCII.GetBytes ( - $"HEAD /static/v.mp4 HTTP/1.1\r\nHost: {baseUri.Authority}\r\n\r\n" + - $"GET /static/after.txt HTTP/1.1\r\nHost: {baseUri.Authority}\r\nConnection: close\r\n\r\n" ), cts.Token ); + $"HEAD /static/v.mp4 HTTP/1.1\r\nHost: {baseUri.Authority}\r\nConnection: close\r\n\r\n" ), cts.Token ); using var received = new MemoryStream (); await stream.CopyToAsync ( received, cts.Token ); @@ -176,8 +174,7 @@ await stream.WriteAsync ( Encoding.ASCII.GetBytes ( string headHeaders = raw [ ..headEnd ]; StringAssert.StartsWith ( headHeaders, "HTTP/1.1 200" ); StringAssert.Contains ( headHeaders.ToLowerInvariant (), "content-length: 300000" ); - StringAssert.StartsWith ( raw [ (headEnd + 4).. ], "HTTP/1.1 200" ); - StringAssert.EndsWith ( raw, "after" ); + Assert.AreEqual ( headEnd + 4, raw.Length ); } [TestMethod]