From 32e3e03f16d15a0563428625b02e811a335d00a2 Mon Sep 17 00:00:00 2001 From: Anand Pant Date: Thu, 19 Nov 2026 00:44:31 -0600 Subject: [PATCH 1/2] chore(deps): upgrade jsdom, CLI widths and Icons hotkeys --- apps/cli/THIRD_PARTY_NOTICES | 4 +- apps/cli/package.json | 2 +- apps/icons/package.json | 2 +- .../src/features/catalog/command-palette.tsx | 3 +- apps/icons/tests/library.test.tsx | 19 +- package.json | 2 +- pnpm-lock.yaml | 229 ++++++------------ 7 files changed, 98 insertions(+), 163 deletions(-) diff --git a/apps/cli/THIRD_PARTY_NOTICES b/apps/cli/THIRD_PARTY_NOTICES index 7418b6993..28810fdb2 100644 --- a/apps/cli/THIRD_PARTY_NOTICES +++ b/apps/cli/THIRD_PARTY_NOTICES @@ -50,8 +50,8 @@ License: - @clack/prompts 1.9.0 and @clack/core 1.6.0 - fast-string-width 3.0.2, fast-wrap-ansi 0.2.2, and sisteransi 2.0.0 - chalk 6.0.0 -- string-width 8.2.2, get-east-asian-width 1.6.0, and strip-ansi 7.2.0 -- wrap-ansi 10.0.0 and ansi-styles 6.2.3 +- string-width 9.0.0 and 8.3.0, get-east-asian-width 1.7.0, and strip-ansi 7.2.0 +- wrap-ansi 10.0.2 and ansi-styles 6.2.3 Copyright (c) 2025-Present Bombshell contributors Copyright (c) 2024-present Fabio Spampinato diff --git a/apps/cli/package.json b/apps/cli/package.json index 2fc1ad4c4..db6920feb 100644 --- a/apps/cli/package.json +++ b/apps/cli/package.json @@ -21,7 +21,7 @@ "is-ci": "4.1.0", "linkedom": "0.18.15", "pako": "3.0.3", - "string-width": "8.3.0", + "string-width": "9.0.0", "wrap-ansi": "10.0.2", "@sketchi/community-icons": "workspace:*", "@sketchi/drawing": "workspace:*", diff --git a/apps/icons/package.json b/apps/icons/package.json index ad722f901..4d752b7c2 100644 --- a/apps/icons/package.json +++ b/apps/icons/package.json @@ -7,7 +7,7 @@ "@sketchi/drawing": "workspace:*", "@sketchi/icon-catalog": "workspace:*", "@sketchi/ui": "workspace:*", - "@tanstack/react-hotkeys": "0.19.0", + "@tanstack/react-hotkeys": "0.27.0", "fflate": "0.8.3", "lucide-react": "1.74.0", "roughjs": "4.6.6", diff --git a/apps/icons/src/features/catalog/command-palette.tsx b/apps/icons/src/features/catalog/command-palette.tsx index 13ce16601..c93bf6375 100644 --- a/apps/icons/src/features/catalog/command-palette.tsx +++ b/apps/icons/src/features/catalog/command-palette.tsx @@ -15,7 +15,7 @@ import { DialogTitle, } from "@sketchi/ui/components/dialog"; import { formatCollectionLabel } from "@sketchi/icon-catalog"; -import { formatForDisplay, type Hotkey } from "@tanstack/react-hotkeys"; +import { useFormatForDisplay, type Hotkey } from "@tanstack/react-hotkeys"; import { Check } from "lucide-react"; import { useRef } from "react"; @@ -63,6 +63,7 @@ export function CommandPalette({ open: boolean; options: readonly (readonly [string, number])[]; }) { + const formatForDisplay = useFormatForDisplay(); // The palette opens from Mod+K or a header button, never a DialogTrigger, so // Radix has no trigger to hand focus back to. It records whatever had focus // as it opens and puts focus back there on close, unless the chosen command diff --git a/apps/icons/tests/library.test.tsx b/apps/icons/tests/library.test.tsx index e31429020..e058c8f3f 100644 --- a/apps/icons/tests/library.test.tsx +++ b/apps/icons/tests/library.test.tsx @@ -144,7 +144,7 @@ describe("IconLibrary", () => { fireEvent.change(search(), { target: { value: "icon" } }); const selectAll = screen.getByRole("checkbox", { name: "Select 300 of 400 results" }); expect(selectAll.parentElement?.textContent).toBe("Select 300"); - fireEvent.click(selectAll); + expect(fireEvent.keyDown(document, { ctrlKey: true, key: "a" })).toBe(false); expect(selectionBar()?.textContent).toContain("300 selected"); expect(selectionBar()?.textContent).toContain("Limit 300"); expect(screen.getByText("Selected 300, 100 left out at the 300 icon cap.")).toBeTruthy(); @@ -153,6 +153,23 @@ describe("IconLibrary", () => { ).toBe(true); }); + it("gives the open command palette the first Escape without clearing the search", async () => { + render(); + fireEvent.change(search(), { target: { value: "k8s" } }); + fireEvent.keyDown(search(), { ctrlKey: true, key: "k" }); + expect(screen.getByRole("dialog", { name: "Commands" })).toBeTruthy(); + + fireEvent.keyDown(screen.getByPlaceholderText("Type a command or collection"), { + key: "Escape", + }); + await waitFor(() => { + expect(screen.queryByRole("dialog", { name: "Commands" })).toBeNull(); + }); + expect(search().value).toBe("k8s"); + expect(fireEvent.keyDown(document, { key: "Escape" })).toBe(false); + expect(search().value).toBe(""); + }); + it("downloads exactly the selection, including icons the filter hides", async () => { let zipped: Blob | undefined; vi.spyOn(URL, "createObjectURL").mockImplementation((blob) => { diff --git a/package.json b/package.json index f1483da18..c063ea3a4 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ "@vitejs/plugin-react": "6.3.0", "eslint-plugin-better-tailwindcss": "4.11.0", "jiti": "2.7.0", - "jsdom": "30.1.3", + "jsdom": "31.0.1", "nx": "24.0.6", "oxfmt": "0.79.0", "oxlint": "1.94.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index b07b359fd..4a898a1c6 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -250,7 +250,7 @@ importers: version: 0.70.0 '@effect/vitest': specifier: 'catalog:' - version: 4.1.4(effect@4.1.4)(vitest@5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@30.1.3)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0))) + version: 4.1.4(effect@4.1.4)(vitest@5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@31.0.1)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0))) '@nx/eslint-plugin': specifier: 24.0.6 version: 24.0.6(@babel/traverse@7.29.8(supports-color@10.2.2))(@swc-node/register@1.12.1(@swc/core@1.16.22(@swc/helpers@0.5.24))(@swc/types@0.1.28)(@typescript/typescript6@6.0.2)(supports-color@10.2.2))(@swc/cli@0.8.2(@swc/core@1.16.22(@swc/helpers@0.5.24))(chokidar@5.0.0)(supports-color@10.2.2))(@swc/core@1.16.22(@swc/helpers@0.5.24))(@typescript-eslint/parser@8.71.1(@typescript/typescript6@6.0.2)(eslint@10.12.0(jiti@2.7.0)(supports-color@10.2.2))(supports-color@10.2.2))(@typescript/typescript6@6.0.2)(eslint-config-prettier@10.1.8(eslint@10.12.0(jiti@2.7.0)(supports-color@10.2.2)))(eslint@10.12.0(jiti@2.7.0)(supports-color@10.2.2))(nx@24.0.6(@swc-node/register@1.12.1(@swc/core@1.16.22(@swc/helpers@0.5.24))(@swc/types@0.1.28)(@typescript/typescript6@6.0.2)(supports-color@10.2.2))(@swc/core@1.16.22(@swc/helpers@0.5.24)))(supports-color@10.2.2) @@ -306,8 +306,8 @@ importers: specifier: 2.7.0 version: 2.7.0 jsdom: - specifier: 30.1.3 - version: 30.1.3 + specifier: 31.0.1 + version: 31.0.1 nx: specifier: 24.0.6 version: 24.0.6(@swc-node/register@1.12.1(@swc/core@1.16.22(@swc/helpers@0.5.24))(@swc/types@0.1.28)(@typescript/typescript6@6.0.2)(supports-color@10.2.2))(@swc/core@1.16.22(@swc/helpers@0.5.24)) @@ -331,7 +331,7 @@ importers: version: 8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0) vitest: specifier: 5.1.0 - version: 5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@30.1.3)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)) + version: 5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@31.0.1)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)) wrangler: specifier: 4.164.0 version: 4.164.0(@types/node@26.6.6) @@ -381,8 +381,8 @@ importers: specifier: 3.0.3 version: 3.0.3 string-width: - specifier: 8.3.0 - version: 8.3.0 + specifier: 9.0.0 + version: 9.0.0 wrap-ansi: specifier: 10.0.2 version: 10.0.2 @@ -448,8 +448,8 @@ importers: specifier: workspace:* version: link:../../packages/ui '@tanstack/react-hotkeys': - specifier: 0.19.0 - version: 0.19.0(react-dom@19.3.1(react@19.3.1))(react@19.3.1) + specifier: 0.27.0 + version: 0.27.0(react-dom@19.3.1(react@19.3.1))(react@19.3.1) effect: specifier: 'catalog:' version: 4.1.4 @@ -885,14 +885,6 @@ packages: '@antfu/install-pkg@2.1.0': resolution: {integrity: sha512-sdg9NxU3zR4Mnawfbc/x6GB5Wf17WYud5qOuEuxXjaKpYpMkISSJEjItGebXJ2bQ4DIcly4NYH23mtkGJjvKUw==} - '@asamuzakjp/css-color@7.1.3': - resolution: {integrity: sha512-1t1U8Cm3RBl9vh3RAZhjkPaduzLSvQJRToRrxpGR/eDRW99mOREleuu+mWfiFa795bUzjwht7NgphCKTs2ianQ==} - engines: {node: ^22.22.2 || ^24.15.0 || >=26.0.0} - - '@asamuzakjp/dom-selector@10.0.5': - resolution: {integrity: sha512-EgmJ7oEaGQECTn3H3wmnQpEy4hKY66VvM7VQndwPIQob3p877BgbyOUE3EX0LgXQCciF2H8KMdR+RznqjMNOLw==} - engines: {node: ^22.22.2 || ^24.15.0 || >=26.0.0} - '@babel/code-frame@7.29.7': resolution: {integrity: sha512-Aup7aUOfpbAUg2ROOJN6Iw5f9DMBlzu0mIkm/malLQFN/YQgO48wCj0Kxa3sEHJvPVFg7siR+qRInwXd2qhQKw==} engines: {node: '>=6.9.0'} @@ -1502,10 +1494,6 @@ packages: '@braintree/sanitize-url@7.1.2': resolution: {integrity: sha512-jigsZK+sMF/cuiB7sERuo9V7N9jx+dhmHHnQyDSVdpZwVutaBu7WvNYqMDLSgFgfB30n452TP3vjDAvFC973mA==} - '@bramus/specificity@2.4.3': - resolution: {integrity: sha512-0GEz8qJWokkUVYQYRukmkSHIFNoBH8QTreeHrAFbvz1XFYc3Y+puhMs8PQ5x8GNugiC2l5jvDBXKLbBIByeSBw==} - hasBin: true - '@cacheable/memory@2.2.0': resolution: {integrity: sha512-CTLKqLItRCEixEAewD3/j9DB3/o96gpTPD4eJ1v+DGOlxZRZncRQkGYqqnAGCscYd6RNeXfGeiuCphsPtqyIfQ==} @@ -1729,42 +1717,6 @@ packages: resolution: {integrity: sha512-IchNf6dN4tHoMFIn/7OE8LWZ19Y6q/67Bmf6vnGREv8RSbBVb9LPJxEcnwrcwX6ixSvaiGoomAUvu4YSxXrVgw==} engines: {node: '>=12'} - '@csstools/color-helpers@6.1.2': - resolution: {integrity: sha512-grhRy3OKmniaAEKXMjua5z/EODX0MSqBGjunw8+j/3HQjOnahs2AGhvEOIYVUWcU6ScApbhLhVrQTX8XqrMrow==} - engines: {node: '>=20.19.0'} - - '@csstools/css-calc@3.4.3': - resolution: {integrity: sha512-iex20d8CHVkyvg6B7UKV7uHnI2Bqo9g+EFfT9E0y+GvTvhZ/DwONJ+9aKb1dlqm0ZiGsL5RXjp0fCoJYnkeDjA==} - engines: {node: '>=20.19.0'} - peerDependencies: - '@csstools/css-parser-algorithms': ^4.0.2 - '@csstools/css-tokenizer': ^4.0.2 - - '@csstools/css-color-parser@4.2.6': - resolution: {integrity: sha512-iiPQ3iRWwnJkeEn6RIu6SJPr7hYrLz6XZ9s/QZl+2/LI5KQVjpl2fdmDSZKuD4xP6GMmMPgHFFXg6k1Wkz0Trg==} - engines: {node: '>=20.19.0'} - peerDependencies: - '@csstools/css-parser-algorithms': ^4.0.2 - '@csstools/css-tokenizer': ^4.0.2 - - '@csstools/css-parser-algorithms@4.0.2': - resolution: {integrity: sha512-40cSKyMvK+tq4qz6Awrlye2WGuOKt3FwPgtGg6KTfbHOWNw+Rk1rzbAtZnZ6IBhsY491HLRnDXwoyBAijmmILA==} - engines: {node: '>=20.19.0'} - peerDependencies: - '@csstools/css-tokenizer': ^4.0.2 - - '@csstools/css-syntax-patches-for-csstree@1.1.15': - resolution: {integrity: sha512-J0u7HkVl2nzSlhsiTOp4AmwcUQ3D+mGEEKfBy/7To5/y7F2OHwyLrXfrhR0SMgr4p5Lo+eaMVSeai24zUcBIxA==} - peerDependencies: - css-tree: ^3.2.1 - peerDependenciesMeta: - css-tree: - optional: true - - '@csstools/css-tokenizer@4.0.2': - resolution: {integrity: sha512-OoKoR0f76dCY666JlcbhmVTs2drYj1GUXZTYTcbUgJjh9Nv41aFfZ21bPQTERm5+L5cBDo466NltB2lplS5GBw==} - engines: {node: '>=20.19.0'} - '@dual-bundle/import-meta-resolve@4.2.1': resolution: {integrity: sha512-id+7YRUgoUX6CgV0DtuhirQWodeeA7Lf4i2x71JS/vtA5pRb/hIGWlw+G6MeXvsM+MXrz0VAydTGElX1rAfgPg==} @@ -5210,12 +5162,12 @@ packages: resolution: {integrity: sha512-w1+YvwmTkwt5n8yUqEH3IWZ9DsmorCZW/EQ3KYHnqEgIkOZpH54NvW6/Epq3Dzb8H0ifIeYX8PExvrNLIH5FIA==} engines: {node: '>=20.19'} - '@tanstack/hotkeys@0.20.0': - resolution: {integrity: sha512-dH9r8ZCCAcjQTcTSHlHooJgnTfS5AGnTbo7mZ9VfM6ZGGWWVA0lea7tUs3oAO2lWS5keYWrH+hg8hmGjmdNrbQ==} + '@tanstack/hotkeys@0.32.0': + resolution: {integrity: sha512-RofohKwXpAtnySoa/sXCWjkA3fyWn8AKcxXO6/Uc/r+ufNiMAyYSmwpVmT7L9hzRNta9ai10Y2soKKfmK5tL8Q==} engines: {node: '>=20'} - '@tanstack/react-hotkeys@0.19.0': - resolution: {integrity: sha512-k5aJOd3tbn2SOwquAH2+eW5lfLxXV1wGvG/8qmux/AzuortslVPfve1KBbPivgew0nb6/3hPMegHML1Qi3aqYQ==} + '@tanstack/react-hotkeys@0.27.0': + resolution: {integrity: sha512-R+XKpXHWIXiQbP4gCogDdqc2uEiHQtZ63rqILZySI595rEHGtFqEkyqrtTkENtu7J8QGan/13xCx18XVdOQuRA==} engines: {node: '>=20'} peerDependencies: react: '>=18.0.0' @@ -6040,8 +5992,11 @@ packages: engines: {node: '>=6.0.0'} hasBin: true - bidi-js@1.1.0: - resolution: {integrity: sha512-fX1Onk0tdVPC7obPWB5EbJ1z7NVhLq4m2xZLq2YXBkxzMXIGRpNMU88n0EPgWseKl12J7zXs7qrDxPK4sRs2fg==} + bcp-47-match@2.0.3: + resolution: {integrity: sha512-JtTezzbAibu8G0R9op9zb3vcWZd9JF6M0xOYGPn0fNCd7wOpRB1mU2mH9T8gaBGbAAyIIVgB2G7xG0GP98zMAQ==} + + bcp-47@2.1.2: + resolution: {integrity: sha512-wsv86UuNFuPnVieKLyECTT+CP1WSAHeoIg5P3xu2kA9Z+7fVPoKt7dxzSeEhtJel0AI+NW3fIW3KtTKQKUCngg==} binary-extensions@2.3.0: resolution: {integrity: sha512-Ceh+7ox5qe7LJuLHoY0feh3pHuUDHAcRUeyL2VYghZwfpkNIy/+8Ocg0a3UuSoYzavmylwuLWQOf3hl0jjMMIw==} @@ -6344,10 +6299,6 @@ packages: resolution: {integrity: sha512-snmjEVXy+1LnwXdxhYvTMj1d9tOh4HxkA1YmoayVBeeyR2C14Pum7fcxJIm4SswYspVy866eYNwlH6xC3/VH5g==} engines: {node: '>=20.19.0'} - css-tree@3.2.1: - resolution: {integrity: sha512-X7sjQzceUhu1u7Y/ylrRZFU2FS6LRiFVp6rKLPg23y3x3c3DOKAwuXGDp+PAGjh6CSnCjYeAul8pcT8bAl+lSA==} - engines: {node: ^10 || ^12.20.0 || ^14.13.0 || >=15.0.0} - css-what@8.0.0: resolution: {integrity: sha512-DH0Bqq3DNp5tdOReuNyAA+Ev4Y2GS5FMbZpeTLP6C4CDi0h5nL0BmUPChXw3o/qbHLDWHl49sbNqQVY7bMSDdw==} engines: {node: '>=20.19.0'} @@ -6704,6 +6655,10 @@ packages: resolution: {integrity: sha512-kxL7msIffSuh9aaFAMD7rxAIuTRMAHMeBtgHW2yUdWw732ZNh4MehkF2gdjvtdmikkaIP9bFDDJOPlsvm7avrA==} engines: {node: '>=20.19.0'} + entities@9.0.0: + resolution: {integrity: sha512-oJFNDJg3kTPwAD1cNn2+WmUq4wFoo09npc3Ydf1D7ED4smRiWrsKnaLxykrTWgyGEcusc87P5dxlAleol9kpkg==} + engines: {node: '>=20.19.0'} + error-ex@1.3.4: resolution: {integrity: sha512-sqQamAnR14VgCr1A618A3sGrygcpK+HEbenA/HiEAkkUwcZIIB/tgWqHFxWgOyDh4nB4JCRimh79dR5Ywc9MDQ==} @@ -7403,13 +7358,13 @@ packages: resolution: {integrity: sha512-SFNOvSJ+Dgf/9An904Yx+CgSlIPCkIpao4qo51lpee25TIRejdH3rhR4EZMGoNx3/TP3O+wzWuiTFl4sqbltzA==} hasBin: true - jsdom@30.1.3: - resolution: {integrity: sha512-hQMUPvRgN7KxsfIytDQji7bimuJeRQa6Qo5+iuiZQk5CafeRxLIA10/cG5YCBFNpD9RO3oqIiN4CO1Y44kxqXg==} + jsdom@31.0.1: + resolution: {integrity: sha512-CbhJL8ZQg3eKswxSZth4QO9tW0jPIhmR0vtSXQSbKSfWbwIT6hoRc17wdHIVTQ43KI0mdV5iTJr3281IDgVZ5g==} engines: {node: ^22.22.2 || ^24.15.0 || >=26.0.0} peerDependencies: - canvas: ^3.2.3 + '@napi-rs/canvas': ^1.0.13 peerDependenciesMeta: - canvas: + '@napi-rs/canvas': optional: true jsesc@3.1.0: @@ -7718,9 +7673,6 @@ packages: mdast-util-to-string@4.0.0: resolution: {integrity: sha512-0H44vDimn51F0YwvxSJSm0eCDOJTRlmN0R1yBh4HLj9wiV1Dn0QoXGbvFAWj2hSItVTlCmBF1hqKlIyUBVFLPg==} - mdn-data@2.27.1: - resolution: {integrity: sha512-9Yubnt3e8A0OKwxYSXyhLymGW4sCufcLG6VdiDdUGVkPhpqLxlvP5vl1983gQjJl3tqbrM731mjaZaP68AgosQ==} - mdn-data@2.37.2: resolution: {integrity: sha512-rz9YOBGItdSbe7HcSArUbhiAv4SB/4DKRYg96CSFS2CcIYMbUvBtZlzA1NCbk2AdgbmYwMqwNblLpR441lLeiQ==} @@ -8142,11 +8094,14 @@ packages: resolution: {integrity: sha512-ayCKvm/phCGxOkYRSCM82iDwct8/EonSEgCSxWxD7ve6jHggsFl4fZVQBPRNgQoKiuV/odhFrGzQXZwbifC8Rg==} engines: {node: '>=8'} + parse5-parser-stream@8.1.1: + resolution: {integrity: sha512-hMcVbbUJcQmP8rURWUdYrT1flRiBiBVjq/RYGguJpDUgIXSqdYKlE0CxthmdMWoSlBAuL5bUBa73g0pttSy7Hw==} + parse5@7.3.0: resolution: {integrity: sha512-IInvU7fabl34qmi9gY8XOVxhYyMyuH2xUNpb2q8/Y+7552KlejkRvqvD19nMoUW/uQGGbqNpA6Tufu5FL5BZgw==} - parse5@8.0.1: - resolution: {integrity: sha512-z1e/HMG90obSGeidlli3hj7cbocou0/wa5HacvI3ASx34PecNjNQeaHNo5WIZpWofN9kgkqV1q5YvXe3F0FoPw==} + parse5@8.1.1: + resolution: {integrity: sha512-EcR/6WDcU7b2N3vQSxKALCk9lXGtUMQxXio008OEMBE0kavu/7JLfBEeFPzi43nMqVDSbEn3QCK+BMCc9zO//w==} parseurl@1.3.3: resolution: {integrity: sha512-CiyeOxFT/JZyN5m0z9PfXw4SCBJ6Sygz1Dpl0wqjlhDEGGBP1GnsUVEL0p63hoG1fcj3fHynXi9NYO4nWOL+qQ==} @@ -8727,6 +8682,10 @@ packages: resolution: {integrity: sha512-ZbmZM0JCihQN91dWnxoipT2KOEyHqEyfRXUyjuRhW8b/xnqPDoq4gWEVApTVa9db2wN8mmoikgFBbjh71+cGeQ==} engines: {node: '>=20'} + string-width@9.0.0: + resolution: {integrity: sha512-2MOboAIRIszVGZVPA2Zqwj0ujd0o+xAZ5y2ft4OcD4kuVQ4phZxq0Sv7YTY8yaDA2CSMXch1EWTkJw+tTJZTzA==} + engines: {node: '>=22'} + string_decoder@1.3.0: resolution: {integrity: sha512-hkRX8U1WjJFd8LsDJ2yQ/wWWxaopEsABU1XfkM8A+j0+85JAGppt16cr1Whg6KIbb4okU6Mql6BOj+uup/wKeA==} @@ -8973,10 +8932,6 @@ packages: resolution: {integrity: sha512-03KrMbjIFDWQR5RNPrSw3bd1r12JpyFQl9/yxjUbJtqkjmllqC5lFjZh6ujeuJCKr8EOQvRW872Oy/az+nLYxg==} engines: {node: '>=20.18.1'} - undici@8.12.3: - resolution: {integrity: sha512-+fdndUTwBP86cVjihTp21hZHo7d6oj1c/47XPA3lL8mM0XHs+C4EkcjmgRsFnFk2f/UONGDy9ItBItmXsLOQHw==} - engines: {node: '>=22.19.0'} - undici@8.12.4: resolution: {integrity: sha512-8Mx+uNKKER2bA4AdtedkqRbwUCIJFr2nJckXRe5yrDqzePqwLP7VNcctN8/XdmDSbF7mS+jJKIszlL+vbam1VA==} engines: {node: '>=22.19.0'} @@ -9280,8 +9235,8 @@ packages: resolution: {integrity: sha512-sXcNcHOC51uPGF0P/D4NVtrkjSU2fNsm9iog4ZvZJsL3rjoDAzXZhkm2MWt1y+PUdggKAYVoMAIYcs78wJ51Cw==} engines: {node: '>=20'} - whatwg-url@17.2.0: - resolution: {integrity: sha512-IhLIHNcBrzIixC5XXsbr4DxdjajyA5vQ5RwGZMtrUp+GbtE5Nrsge9QKau7jXrC0aTXLYGV0xiW7Tb4YS2aomw==} + whatwg-url@17.3.0: + resolution: {integrity: sha512-KwOAJrpf+GTgBvcBQJcP38sMF0DsQKdwtG+TxM2pW44P6E5k0hDbWrDmyuJDIF0Uef0aQq0ZoJs+5oI+k8ddhg==} engines: {node: ^22.14.0 || >=24.0.0} which@2.0.2: @@ -9497,21 +9452,6 @@ snapshots: package-manager-detector: 1.9.0 tinyexec: 1.3.1 - '@asamuzakjp/css-color@7.1.3': - dependencies: - '@csstools/css-calc': 3.4.3(@csstools/css-parser-algorithms@4.0.2(@csstools/css-tokenizer@4.0.2))(@csstools/css-tokenizer@4.0.2) - '@csstools/css-color-parser': 4.2.6(@csstools/css-parser-algorithms@4.0.2(@csstools/css-tokenizer@4.0.2))(@csstools/css-tokenizer@4.0.2) - '@csstools/css-parser-algorithms': 4.0.2(@csstools/css-tokenizer@4.0.2) - '@csstools/css-tokenizer': 4.0.2 - lru-cache: 11.5.3 - - '@asamuzakjp/dom-selector@10.0.5': - dependencies: - bidi-js: 1.1.0 - css-tree: 3.2.1 - is-potential-custom-element-name: 1.0.1 - lru-cache: 11.5.3 - '@babel/code-frame@7.29.7': dependencies: '@babel/helper-validator-identifier': 7.29.7 @@ -10321,10 +10261,6 @@ snapshots: '@braintree/sanitize-url@7.1.2': {} - '@bramus/specificity@2.4.3': - dependencies: - css-tree: 3.2.1 - '@cacheable/memory@2.2.0': dependencies: '@cacheable/utils': 2.5.0 @@ -10567,30 +10503,6 @@ snapshots: dependencies: '@jridgewell/trace-mapping': 0.3.9 - '@csstools/color-helpers@6.1.2': {} - - '@csstools/css-calc@3.4.3(@csstools/css-parser-algorithms@4.0.2(@csstools/css-tokenizer@4.0.2))(@csstools/css-tokenizer@4.0.2)': - dependencies: - '@csstools/css-parser-algorithms': 4.0.2(@csstools/css-tokenizer@4.0.2) - '@csstools/css-tokenizer': 4.0.2 - - '@csstools/css-color-parser@4.2.6(@csstools/css-parser-algorithms@4.0.2(@csstools/css-tokenizer@4.0.2))(@csstools/css-tokenizer@4.0.2)': - dependencies: - '@csstools/color-helpers': 6.1.2 - '@csstools/css-calc': 3.4.3(@csstools/css-parser-algorithms@4.0.2(@csstools/css-tokenizer@4.0.2))(@csstools/css-tokenizer@4.0.2) - '@csstools/css-parser-algorithms': 4.0.2(@csstools/css-tokenizer@4.0.2) - '@csstools/css-tokenizer': 4.0.2 - - '@csstools/css-parser-algorithms@4.0.2(@csstools/css-tokenizer@4.0.2)': - dependencies: - '@csstools/css-tokenizer': 4.0.2 - - '@csstools/css-syntax-patches-for-csstree@1.1.15(css-tree@3.2.1)': - optionalDependencies: - css-tree: 3.2.1 - - '@csstools/css-tokenizer@4.0.2': {} - '@dual-bundle/import-meta-resolve@4.2.1': {} '@effect/ai-anthropic@4.1.4(effect@4.1.4)': @@ -10674,10 +10586,10 @@ snapshots: '@effect/tsgo-win32-arm64': 0.70.0 '@effect/tsgo-win32-x64': 0.70.0 - '@effect/vitest@4.1.4(effect@4.1.4)(vitest@5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@30.1.3)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)))': + '@effect/vitest@4.1.4(effect@4.1.4)(vitest@5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@31.0.1)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)))': dependencies: effect: 4.1.4 - vitest: 5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@30.1.3)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)) + vitest: 5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@31.0.1)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)) '@emnapi/core@1.11.0': dependencies: @@ -13535,11 +13447,11 @@ snapshots: '@tanstack/history@1.162.5': {} - '@tanstack/hotkeys@0.20.0': {} + '@tanstack/hotkeys@0.32.0': {} - '@tanstack/react-hotkeys@0.19.0(react-dom@19.3.1(react@19.3.1))(react@19.3.1)': + '@tanstack/react-hotkeys@0.27.0(react-dom@19.3.1(react@19.3.1))(react@19.3.1)': dependencies: - '@tanstack/hotkeys': 0.20.0 + '@tanstack/hotkeys': 0.32.0 react: 19.3.1 react-dom: 19.3.1(react@19.3.1) @@ -14500,9 +14412,13 @@ snapshots: baseline-browser-mapping@2.11.27: {} - bidi-js@1.1.0: + bcp-47-match@2.0.3: {} + + bcp-47@2.1.2: dependencies: - require-from-string: 2.0.2 + is-alphabetical: 2.0.1 + is-alphanumerical: 2.0.1 + is-decimal: 2.0.1 binary-extensions@2.3.0: {} @@ -14825,11 +14741,6 @@ snapshots: domutils: 4.0.2 nth-check: 3.0.1 - css-tree@3.2.1: - dependencies: - mdn-data: 2.27.1 - source-map-js: 1.2.2 - css-what@8.0.0: {} css.escape@1.5.1: {} @@ -15025,7 +14936,7 @@ snapshots: data-urls@8.0.0: dependencies: whatwg-mimetype: 5.0.0 - whatwg-url: 17.2.0 + whatwg-url: 17.3.0 transitivePeerDependencies: - '@noble/hashes' @@ -15186,6 +15097,8 @@ snapshots: entities@8.1.0: {} + entities@9.0.0: {} + error-ex@1.3.4: dependencies: is-arrayish: 0.2.1 @@ -16009,27 +15922,25 @@ snapshots: dependencies: argparse: 2.0.1 - jsdom@30.1.3: + jsdom@31.0.1: dependencies: - '@asamuzakjp/css-color': 7.1.3 - '@asamuzakjp/dom-selector': 10.0.5 - '@bramus/specificity': 2.4.3 - '@csstools/css-syntax-patches-for-csstree': 1.1.15(css-tree@3.2.1) '@exodus/bytes': 1.16.0 - css-tree: 3.2.1 + bcp-47: 2.1.2 + bcp-47-match: 2.0.3 data-urls: 8.0.0 decimal.js: 10.6.0 html-encoding-sniffer: 7.0.0 is-potential-custom-element-name: 1.0.1 lru-cache: 11.5.3 - parse5: 8.0.1 + parse5: 8.1.1 + parse5-parser-stream: 8.1.1 saxes: 6.0.0 tough-cookie: 6.0.2 - undici: 8.12.3 + undici: 8.12.4 w3c-xmlserializer: 6.0.0 webidl-conversions: 8.0.1 whatwg-mimetype: 5.0.0 - whatwg-url: 17.2.0 + whatwg-url: 17.3.0 xml-name-validator: 5.0.0 transitivePeerDependencies: - '@noble/hashes' @@ -16420,8 +16331,6 @@ snapshots: dependencies: '@types/mdast': 4.0.4 - mdn-data@2.27.1: {} - mdn-data@2.37.2: {} media-typer@1.1.1: @@ -17177,13 +17086,17 @@ snapshots: json-parse-even-better-errors: 2.3.1 lines-and-columns: 1.2.4 + parse5-parser-stream@8.1.1: + dependencies: + parse5: 8.1.1 + parse5@7.3.0: dependencies: entities: 6.0.1 - parse5@8.0.1: + parse5@8.1.1: dependencies: - entities: 8.1.0 + entities: 9.0.0 parseurl@1.3.3: optional: true @@ -17604,7 +17517,8 @@ snapshots: require-directory@2.1.1: {} - require-from-string@2.0.2: {} + require-from-string@2.0.2: + optional: true resolve-alpn@1.2.1: optional: true @@ -17954,6 +17868,11 @@ snapshots: get-east-asian-width: 1.7.0 strip-ansi: 7.2.0 + string-width@9.0.0: + dependencies: + get-east-asian-width: 1.7.0 + strip-ansi: 7.2.0 + string_decoder@1.3.0: dependencies: safe-buffer: 5.2.1 @@ -18209,8 +18128,6 @@ snapshots: undici@7.30.1: {} - undici@8.12.3: {} - undici@8.12.4: {} unenv@2.0.0-rc.24: @@ -18390,7 +18307,7 @@ snapshots: optionalDependencies: vite: 8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0) - vitest@5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@30.1.3)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)): + vitest@5.1.0(@opentelemetry/api@1.10.0)(@types/node@26.6.6)(jsdom@31.0.1)(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)): dependencies: '@types/chai': 5.2.3 '@vitest/mocker': 5.1.0(vite@8.3.8(@types/node@26.6.6)(esbuild@0.28.2)(jiti@2.7.0)(yaml@2.9.0)) @@ -18409,7 +18326,7 @@ snapshots: optionalDependencies: '@opentelemetry/api': 1.10.0 '@types/node': 26.6.6 - jsdom: 30.1.3 + jsdom: 31.0.1 transitivePeerDependencies: - msw @@ -18451,7 +18368,7 @@ snapshots: whatwg-mimetype@5.0.0: {} - whatwg-url@17.2.0: + whatwg-url@17.3.0: dependencies: '@exodus/bytes': 1.16.0 tr46: 7.0.0 From 9d19074dcd5ffaf91208431dc86459b077ee1566 Mon Sep 17 00:00:00 2001 From: Anand Pant Date: Thu, 19 Nov 2026 00:51:56 -0600 Subject: [PATCH 2/2] fix(cli): truncate list titles at grapheme boundaries --- apps/cli/THIRD_PARTY_NOTICES | 2 +- apps/cli/src/commands/list.ts | 7 ++++--- apps/cli/tests/cli.test.ts | 8 +++++++- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/apps/cli/THIRD_PARTY_NOTICES b/apps/cli/THIRD_PARTY_NOTICES index 28810fdb2..48fff2bf7 100644 --- a/apps/cli/THIRD_PARTY_NOTICES +++ b/apps/cli/THIRD_PARTY_NOTICES @@ -49,7 +49,7 @@ License: - @clack/prompts 1.9.0 and @clack/core 1.6.0 - fast-string-width 3.0.2, fast-wrap-ansi 0.2.2, and sisteransi 2.0.0 -- chalk 6.0.0 +- chalk 6.0.1 - string-width 9.0.0 and 8.3.0, get-east-asian-width 1.7.0, and strip-ansi 7.2.0 - wrap-ansi 10.0.2 and ansi-styles 6.2.3 diff --git a/apps/cli/src/commands/list.ts b/apps/cli/src/commands/list.ts index 3e5b141ce..ec505f13f 100644 --- a/apps/cli/src/commands/list.ts +++ b/apps/cli/src/commands/list.ts @@ -11,13 +11,14 @@ import { rootCommand } from "./root"; const DEFAULT_LIST_LIMIT = 20; const LIST_TITLE_WIDTH = 48; +const graphemes = new Intl.Segmenter(undefined, { granularity: "grapheme" }); function fitWidth(value: string, width: number): string { if (stringWidth(value) <= width) return value; let fitted = ""; - for (const character of value) { - if (stringWidth(`${fitted}${character}…`) > width) break; - fitted += character; + for (const { segment } of graphemes.segment(value)) { + if (stringWidth(`${fitted}${segment}…`) > width) break; + fitted += segment; } return `${fitted}…`; } diff --git a/apps/cli/tests/cli.test.ts b/apps/cli/tests/cli.test.ts index 7c58d8286..9ead61131 100644 --- a/apps/cli/tests/cli.test.ts +++ b/apps/cli/tests/cli.test.ts @@ -143,7 +143,13 @@ describe("sketchi offline command flow", () => { "invalid_document", ); - json(0, ["create", "--file", "-"], `${JSON.stringify(mindmap)}\n`); + const titlePrefix = `${"界".repeat(22)}a`; + const conjunctTitle = `${titlePrefix}ष्ट्र Extra`; + json(0, ["create", "--file", "-"], `${JSON.stringify(retitled(mindmap, conjunctTitle))}\n`); + const list = run(["list"]); + assert.strictEqual(list.status, 0, list.stderr); + const truncated = list.stdout.split("\n").find((line) => line.startsWith("launch-map")); + assert.include(truncated ?? "", `${titlePrefix}…`); json(0, [ "edit", "launch-map",