Skip to content

lcm method overflows for large inputs #76

Description

@johnw42

The lcm method can easily overflow when product of the inputs is too big to fit in the type of the arguments. I suggest adding a checked variant of lcm and related methods that uses checked_mul in the final step.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions